For #6895: Add optional itemDecoration in browser tabs tray.

[mcarare]

---

Pull Request checklist

• Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
• Tests: This PR includes thorough tests or an explanation of why it does not
• Changelog: This PR includes a changelog entry or does not need one
• Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

• Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
• Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

[codecov]

Codecov Report

Merging #6896 into master will decrease coverage by 0.11%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #6896      +/-   ##
============================================
- Coverage     77.33%   77.21%   -0.12%     
+ Complexity     4817     4776      -41     
============================================
  Files           646      641       -5     
  Lines         23570    23402     -168     
  Branches       3469     3434      -35     
============================================
- Hits          18227    18070     -157     
+ Misses         3894     3889       -5     
+ Partials       1449     1443       -6     

Impacted Files	Coverage Δ	Complexity Δ
...lla/components/browser/tabstray/BrowserTabsTray.kt	73.52% <100.00%> (+1.65%)	3.00 <0.00> (+1.00)
...nts/lib/publicsuffixlist/PublicSuffixListLoader.kt
...nents/lib/publicsuffixlist/PublicSuffixListData.kt
...a/components/lib/publicsuffixlist/ext/ByteArray.kt
...illa/components/lib/publicsuffixlist/ext/String.kt
...omponents/lib/publicsuffixlist/PublicSuffixList.kt
...components/support/sync/telemetry/SyncTelemetry.kt	87.09% <0.00%> (+1.38%)	41.00% <0.00%> (ø%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d153d0d...63b71a0. Read the comment docs.

[psymoon]

Looks good, just a small nit.

[jonalmeida]

@mcarare The confusion seems to have come from the lambda in the TabsAdapter that had a tabsTray field. BrowserTabsTray extends from a RecyclerView so you can still make similar errors with this fix.

I agree we need a better API though. 🙂

[mcarare]

@jonalmeida Yes, I think we should take into considerations more use cases and possible pitfalls of using this API. The change in this PR came as a fix to the crash that happens in fenix nightly, caused by the fact that tabsTray.addItemDecoration(decoration) was called before calling the BrowserTabsTray constructor.

[jonalmeida]

Adding the item decoration was not the cause for that bug, but that it was in the scope of the TabsAdapter.viewHolderProvider which is invoked when a new view holder is created.

Maybe we should look into making a better TabsAdapter too?

[mcarare]

@jonalmeida Im not sure we are talking about the same crash. I was referring to this one: mozilla-mobile/fenix#10453

[jonalmeida]

@jonalmeida Im not sure we are talking about the same crash. I was referring to this one: mozilla-mobile/fenix#10453

Yes, this was the fix for it. :)

mozilla-mobile/fenix#10495

[mcarare]

@jonalmeida Im not sure we are talking about the same crash. I was referring to this one: mozilla-mobile/fenix#10453

Yes, this was the fix for it. :)

mozilla-mobile/fenix#10495

Yeah, I already had a PR for that: mozilla-mobile/fenix#10476...

[jonalmeida]

@jonalmeida Im not sure we are talking about the same crash. I was referring to this one: mozilla-mobile/fenix#10453

Yes, this was the fix for it. :)
mozilla-mobile/fenix#10495

Yeah, I already had a PR for that: mozilla-mobile/fenix#10476...

Oh no, I'm sorry! I didn't see any discussion happening on Riot or Slack, so I put up a PR. Apologise for that!

I'm still unsure this change will avoid that bug, but let's try.

[mcarare]

@jonalmeida Np. I have already tried it with local AC build, it works :)

[jonalmeida]

bors r=psymoon

[bors]

Build failed:

• complete-push

[psymoon]

bors retry

[bors]

Build succeeded:

• complete-push