Ability to rename top sites

[gaul]

Why/User Benefit/User Problem

Some sites, e.g., The Guardian, have long titles that abbreviate poorly. For example, "News, sport and opinion from the Guardian's US edition | The Guardian" turns into, "News, spor...". Allowing users to rename these would enable more description titles.

What/Requirements

Long press on top site currently brings up a dialog with "Open in private tab" and "Remove". Add "Rename" which brings up a dialog with current name edit box and cancel and rename buttons. Pressing rename will modify the underlying SQLite database and refresh the page.

Acceptance Criteria (how do I know when I’m done?)

Users can rename top sites.

Update from UX:

• add a new menu entry "Rename" to the menu that appears on long press
• show a dialog (same design that we use for the "create new collection" case) where people can update the name
  

┆Issue is synchronized with this Jira Task

[Matth7878]

Top sites text should also be displayed on 2 lines.
I have 3 top sites for direct link to GitHub Project. If you don't know which one is which it's impossible to tell them apart.

Being able to rename would be a nice improvement but still you got only 11 characters which is really short.
What if I have 2 top sites one for a direct link to commits and another to issues or whatever? (And of course still having other top sites for other GitHub projects)
Having 22 characters would be very useful to have meaningful name.

Not sure if it should be a new issue but I feel it belongs with this one as "Top Sites text should be useful"

[gaul]

Alternatively, it would be nice to allow rename during adding a top site, similar to what is done for adding to the home screen. Or store the top sites in bookmarks so we can use that interface to manage top sites.

[anotherus3r]

Yes, this would be a really useful feature. The Guardian and Euronews are two examples of sites I'd find this feature useful for.

Alternatively, it would be nice to allow rename during adding a top site, similar to what is done for adding to the home screen.

In my opinion, this solution would be somewhat better, but both the original one and this one would be good to have.

[liuche]

Needs minimal some basic UX (we can assume it's a dialog) and need AC db changes.

[AmyYLee]

Assigning to @topotropic

[Matth7878]

Isn't it possible to temporarily expose a rename action on long pressing top sites? It's really annoying when for instance you have pinned multiple pull request page on GitHub -> they all have same icons and all names are pull request....

[gabrielluong]

@betsymi can I have you take look at this copy? Thank you!

[betsymi]

@gabrielluong Clarification question after reading the comments: Are people able to edit the name AND the URL in this view, or only the name?

[sv-ohorvath]

@gabrielluong I started testing this on Nightly, but I would like to know too if we want this, in order to validate these changes:

@gabrielluong Clarification question after reading the comments: Are people able to edit the name AND the URL in this view, or only the name?

I personally don't think that is necessary, since you can just add a new top site with the URL you want, but I need a confirmation.

Also, the frequently visited top sites (the ones coming from the History list) don't have this option (only the pinned top sites). According to this: #10342 (comment) it would be nice to have.
Thanks!

[gabrielluong]

@gabrielluong I started testing this on Nightly, but I would like to know too if we want this, in order to validate these changes:

@gabrielluong Clarification question after reading the comments: Are people able to edit the name AND the URL in this view, or only the name?

I personally don't think that is necessary, since you can just add a new top site with the URL you want, but I need a confirmation.

Also, the frequently visited top sites (the ones coming from the History list) don't have this option (only the pinned top sites). According to this: #10342 (comment) it would be nice to have.
Thanks!

We only covered renaming the name for pinned site. I will check with @vesta0 and @topotropic about further follow ups and file new issues.

[sv-ohorvath]

Ok, thanks. Closing the issue as verified then.

[532910]

It doesn't allow to remove name! Please reopen!

[Dunexus]

This issue was about renaming top sites. If you want to hide top sites name, please open a new issue.

[532910]

Aan empty string is just a special case. Moreover, just space isn't allowed too.