Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Populate top sites with frequently opened sites #10342

Closed
3 tasks done
vesta0 opened this issue May 1, 2020 · 15 comments
Closed
3 tasks done

Populate top sites with frequently opened sites #10342

vesta0 opened this issue May 1, 2020 · 15 comments
Assignees
@gabrielluong
Labels
E5 Estimation Point: about 5 days eng:perf-impact This issue may have an impact on performance: the perf team will investigate eng:qa:verified QA Verified Feature:Shortcuts Top Sites/Topsites on the Firefox home page

Comments

@vesta0
Copy link
Collaborator

vesta0 commented May 1, 2020 •
edited by data-sync-user
Loading

User Story

As a user, I want to see my frequently accessed sites on the homescreen in a useful way, so I can reference them to complete my routine tasks faster.

Dependencies

Acceptance Criteria

  • I can disable this feature
  • If enabled, I see my frequently accessed sites on my homescreen
  • There is a cap on # of automatically generated top sites to avoid cluttering the homescreen
  • Users can turn off this feature in settings (just the auto-populated top sites, not the user added ones) (This is a requirement for shipping this feature)
  • I can customize how my top sites show up on the homescreen (e.g. choose how many sites or rows to see)

Nice to have:

┆Issue is synchronized with this Jira Task
@vesta0 vesta0 added Feature:Shortcuts Top Sites/Topsites on the Firefox home page Skittle labels May 1, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label May 1, 2020
@vesta0 vesta0 changed the title Populate top sites with frequentlyopened sites Populate top sites with frequently opened sites May 1, 2020
@vesta0 vesta0 added the feature request 🌟 New functionality and improvements label May 1, 2020
@cadeyrn
Copy link
Contributor

cadeyrn commented May 1, 2020

Can you please make this an optional feature? I really don't want my homescreen cluttered with auto-populated sites. It's always the first thing I disable in new installations of Firefox on desktop systems and Firefox for Android should allow to disable this, too. Thanks!

@vesta0
Copy link
Collaborator Author

vesta0 commented May 1, 2020

@cadeyrn thanks for the feedback! I added that to the acceptance criteria.

@kbrosnan kbrosnan mentioned this issue May 7, 2020
Closed
@Kreuger
Copy link

Kreuger commented May 7, 2020

I would also like to see some news articles featured like Kiwi Browser has.

@cadeyrn
Copy link
Contributor

cadeyrn commented May 7, 2020

News articles seems more something for #6416. This issue is about the top site thumbnails - there is no space for a headline or text.

@vesta0 vesta0 removed the needs:triage Issue needs triage label May 7, 2020
@gabrielluong gabrielluong self-assigned this May 7, 2020
@gabrielluong gabrielluong added the E13 Estimation Point: about 10 days label May 8, 2020
@vesta0 vesta0 added P1 Current sprint P2 Upcoming release and removed P1 Current sprint labels May 13, 2020
@gabrielluong gabrielluong mentioned this issue May 25, 2020
Closed
@vesta0 vesta0 mentioned this issue May 25, 2020
Closed
@gabrielluong gabrielluong added E5 Estimation Point: about 5 days and removed E13 Estimation Point: about 10 days labels May 26, 2020
@boek boek mentioned this issue Jun 3, 2020
Closed
15 tasks
@liuche
Copy link
Contributor

liuche commented Jun 4, 2020

This is partly there, and gl can do a demo on 6/5 to decide whether to put this into release, and will need to fix fallout during codefreeze time (40% confidence that good enough right now), or can be a fast-follow after releaese.

@gabrielluong gabrielluong mentioned this issue Jun 4, 2020
Closed
4 tasks
gabrielluong added a commit to gabrielluong/fenix that referenced this issue Jun 5, 2020
@gabrielluong
For mozilla-mobile#10342: Populate top sites with frequently opened s…
90f3310 
…ites
csadilek pushed a commit to csadilek/fenix that referenced this issue Aug 26, 2020
@gabrielluong @csadilek
For mozilla-mobile#10342 - Part 5: Fix DefaultSessionControlControlle…
82bf822 
…rTest and DefaultBrowserToolbarControllerTest
csadilek pushed a commit to csadilek/fenix that referenced this issue Aug 26, 2020
@gabrielluong @csadilek
For mozilla-mobile#10342 - Part 6: Show "Delete from history" instead…
92a04e7 
… of "Remove" for top frecent sites in the top site menu
csadilek pushed a commit to csadilek/fenix that referenced this issue Aug 26, 2020
@gabrielluong @csadilek
For mozilla-mobile#10342 - Part 7: Fix TopSiteViewHolderTest and TopS…
b4c7426 
…iteItemViewHolderTest
jonalmeida pushed a commit that referenced this issue Aug 26, 2020
@gabrielluong @jonalmeida
For #10342 - Part 1: Remove top sites prefetch and observation of liv…
7d9274e 
…e data
jonalmeida pushed a commit that referenced this issue Aug 26, 2020
@gabrielluong @jonalmeida
For #10342 - Part 2: Replace the local TopSiteStorage with the A-C De…
d824dd1 
…faultTopSiteStorage
jonalmeida pushed a commit that referenced this issue Aug 26, 2020
@gabrielluong @jonalmeida
For #10342 - Part 3: Use the TopSitesUseCase in the BrowserToolbarCon…
46aa6a0 
…troller and SessionControlController

Use the provided `addPinnedSites` and `removeTopSites` use cases in `BrowserToolbarController` and `SessionControlController`.
jonalmeida pushed a commit that referenced this issue Aug 26, 2020
@gabrielluong @jonalmeida
For #10342 - Part 4: Use the TopSitesFeature in the HomeFragment for …
1f564c1 
…displaying top sites
jonalmeida pushed a commit that referenced this issue Aug 26, 2020
@gabrielluong @jonalmeida
For #10342 - Part 5: Fix DefaultSessionControlControllerTest and Defa…
40120ac 
…ultBrowserToolbarControllerTest
jonalmeida pushed a commit that referenced this issue Aug 26, 2020
@gabrielluong @jonalmeida
For #10342 - Part 6: Show "Delete from history" instead of "Remove" f…
4f76699 
…or top frecent sites in the top site menu
jonalmeida pushed a commit that referenced this issue Aug 26, 2020
@gabrielluong @jonalmeida
For #10342 - Part 7: Fix TopSiteViewHolderTest and TopSiteItemViewHol…
0cc1d32 
…derTest
@gabrielluong gabrielluong added the eng:qa:needed QA Needed label Aug 26, 2020
@gabrielluong
Copy link
Member

Feature is currently hidden behind the Secret Menu to display visited sites.

@Matth7878
Copy link

Having tested it I am wondering if it should not be apart from top sites : they have been limited to 8 (x2) and that's not a lot.
And for people not wanting it it may be easier to turn it off?

Besides it didn't matter for top sites but for frequent sites having a thumbnails instead of an icon would really be better. You may not be as familiar with them than you are with top sites.

@LaurentiuApahideanSV
Copy link

Verified as fixed on Firefox Preview Nightly 200827 (Build #2015760379).

Devices used:

  • OnePlus 6T (Android 9)
  • Huawei MediaPad M3 (Android 7.0)

@LaurentiuApahideanSV LaurentiuApahideanSV added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Aug 27, 2020
@madb1lly
Copy link

madb1lly commented Aug 27, 2020 •
edited
Loading

Hi @Matth7878,

I agree, I don't know what half of those frequently visited sites are from the icon that's used! 😆

Cheers 🙂

@gabrielluong gabrielluong added the eng:perf-impact This issue may have an impact on performance: the perf team will investigate label Aug 27, 2020
@dglttr dglttr mentioned this issue Aug 27, 2020
Closed
@liuche liuche mentioned this issue Aug 31, 2020
Closed
@LaurentiuApahideanSV
Copy link

I tested the issue on Firefox Preview Beta 81.1.0-beta.1. The patch notes for this build contain this fix but the top sites are not populated with the most visited websites and the Secret settings menu is blank.

Devices used:

  • Huawei MediaPad M3 (Android 7.0)
  • OnePlus 6T (Android 9)

@LaurentiuApahideanSV
Copy link

The option is not present in the Customize Settings menu, I have reopened issue #14119 regarding this.

@liuche liuche mentioned this issue Sep 2, 2020
Merged
3 tasks
@LaurentiuApahideanSV
Copy link

Verified as fixed on Firefox Preview Beta 81.1.0-beta.2 (Build #2015761657).

Devices used:

  • Huawei MediaPad M3 (Android 7.0)
  • OnePlus 6T (Android 9)

@sv-ohorvath sv-ohorvath mentioned this issue Nov 2, 2020
Closed
@data-sync-user data-sync-user changed the title FNX-3447 ⁃ Populate top sites with frequently opened sites Populate top sites with frequently opened sites May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gabrielluong gabrielluong

Labels
E5 Estimation Point: about 5 days eng:perf-impact This issue may have an impact on performance: the perf team will investigate eng:qa:verified QA Verified Feature:Shortcuts Top Sites/Topsites on the Firefox home page
Projects
None yet
Milestone
No milestone
10 participants
@Kreuger @liuche @cadeyrn @gabrielluong @Matth7878 @madb1lly @vesta0 @LaurentiuApahideanSV @data-sync-user @binocry