Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Edit Logins #9504

Closed
6 tasks done
vesta0 opened this issue Mar 30, 2020 · 5 comments · Fixed by #9693
Closed
6 tasks done

Edit Logins #9504

vesta0 opened this issue Mar 30, 2020 · 5 comments · Fixed by #9693
Assignees
@AmyYLee @eliserichards
Labels
E13 Estimation Point: about 10 days eng:ready Ready for engineering Feature:Logins

Comments

@vesta0
Copy link
Collaborator

vesta0 commented Mar 30, 2020 •
edited by data-sync-user
Loading

User Story

As a user, I want to be able to edit my logins, so I have control over changing them manually.

Acceptance Criteria

I can edit my logins in Logins settings

  • Add kebab (three dot) menu to login info toolbar with options to edit and delete
  • Add fragment with editable fields
    • disable web address editing - YES
  • Error states
    • possibly break this out into a separate piece of work?
  • Save enabled only when valid
    • Successful save routes to site info page
  • Cancel (X) button
    • where does cancel route to - login info
    • do we want a confirmation dialog - no
  • Feature flags

Designs

UX Mocks

SVG Icons

checkmark
drop-down arrow
warning
clear text field

┆Issue is synchronized with this Jira Task
@vesta0 vesta0 added Feature:Logins eng:ready Ready for engineering labels Mar 30, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Mar 30, 2020
@vesta0 vesta0 removed the needs:triage Issue needs triage label Mar 30, 2020
@vesta0 vesta0 mentioned this issue Mar 30, 2020
Closed
4 tasks
@eliserichards
Copy link

@jonichan Hey Joni! Just wanted to let you know that I will be starting this issue soon and I'll reach out to you about getting some help docs on the SUMO site! 😄

@eliserichards eliserichards mentioned this issue Apr 3, 2020
Merged
10 tasks
eliserichards pushed a commit that referenced this issue May 12, 2020
Fixes #9504: Edit logins (#9693)
edc75c3 
* Create editable view and fragment. Update login info page to display options menu with edit and delete.

* Create feature flag for edit. Check flag in the login detail fragment and default to just delete.

* Add three-dot kebab options menu in login detail fragment. Add title to the login item.

* Nav to and from edit view on save and back pressed.

* Save login through AC login manager. Clear text in editable field on button click.

* Match colors, fonts, dimens to UX specs for edit logins. Enable password reveal/hide and clearing text fields.

* Refactoring logins fragments. Using component Login object for consistency.

Fetch login list when saved logins are opened. Fetch login details when detail view is opened.

Revert "Fetch login list when saved logins are opened. Fetch login details when detail view is opened."

This reverts commit 44fe171.

* Using parcelable login and Login component class to pass ids and items between fragments

* Retrieve login from storage when viewing login details.

Rename login logic for consistency.

Ktlint cleanup

Fix nits and naming consistency.

* UX consistency for login detail and edit login pages

* Rebasing with logins sort - updating logins store.

* Rebasing with logins sort - merging fragments and controllers.

* Lint and removing unused files.

* UX cleanup.

* Update string description
@eliserichards eliserichards mentioned this issue May 12, 2020
Closed
@ekager ekager added the eng:qa:needed QA Needed label May 13, 2020
@ekager
Copy link
Contributor

ekager commented May 13, 2020

Reopening for QA

@ekager ekager reopened this May 13, 2020
@liuche liuche mentioned this issue May 19, 2020
Closed
32 tasks
@ebalazs-sv
Copy link

ebalazs-sv commented May 21, 2020 •
edited
Loading

Hi!
I tested this on Fenix Nightly Build 21420606 from 5/21 with Nexus 5 (Android 6.0.1), Motorola Moto G6 (Android 8), Google Pixel 2 (Android 9) and these are the results:

Status Options/Settings Notes
✔️ Kebab ⋮ button This button is displayed as in the UX Mocks
❓ Kebab ⋮ button menu (Edit & Delete) Different menu style compared to the one from the sort logins section
✔️ Fragment with editable fields The Username and Password fields are editable
✔️ Fragment with editable fields - disable web address editing The Site is not editable
❓ Fragment with editable fields The show/hide button is actionable on the all Password field
❓ Fragment with editable fields The password becomes uneditable if tapped anywhere else than the end of the password
❓ Save enabled only when valid - Successful save routes to site info page The edited login can be saved even if the username field is empty or left incomplete
❓ Error states This is not available
❓ Cancel (X) button This is not available

CC @eliserichards and @AmyYLee Please review and advice the above findings.
Also the Error states and Cancel button are not implemented.

There is filed one issue related to this:
#10725

I will remove the qa:needed until further notice. Thanks!

@abodea abodea removed the eng:qa:needed QA Needed label May 21, 2020
@eliserichards
Copy link

Moving this to "done" as the missing pieces haven't been implemented yet (#10173 and #10172)

@liuche
Copy link
Contributor

liuche commented May 22, 2020

Close this issue because the subsequent pieces will be in the follow-ups, that have been filed.

@liuche liuche closed this as completed May 22, 2020
@liuche liuche added the E13 Estimation Point: about 10 days label May 22, 2020
@liuche liuche mentioned this issue Jun 5, 2020
Closed
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AmyYLee AmyYLee

@eliserichards eliserichards

Labels
E13 Estimation Point: about 10 days eng:ready Ready for engineering Feature:Logins
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #9504: Edit logins eliserichards/fenix
7 participants
@liuche @AmyYLee @ekager @vesta0 @abodea @eliserichards @ebalazs-sv