Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Error states for saved logins #10172

Closed
3 tasks done
eliserichards opened this issue Apr 24, 2020 · 1 comment
Closed
3 tasks done

Error states for saved logins #10172

eliserichards opened this issue Apr 24, 2020 · 1 comment
Assignees
@eliserichards
Labels
E3 Estimation Point: average, 2 - 3 days eng:qa:verified QA Verified Feature:Logins

Comments

@eliserichards
Copy link

eliserichards commented Apr 24, 2020 •
edited by data-sync-user
Loading

Cleanup keyboard actions on the edit login fragment and finalize error states (including dupe usernames).

For QA 🎉

The PR has more details about what this card does and does not cover. Both this and #10173 are follow-ups to #9693.

Acceptance Criteria

  • password cannot be empty/null
  • username can be empty/null
  • open keyboard when clicking into editable text fields (this should work)

┆Issue is synchronized with this Jira Task
@eliserichards eliserichards added E3 Estimation Point: average, 2 - 3 days Feature:Logins labels Apr 24, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Apr 24, 2020
@eliserichards eliserichards removed the needs:triage Issue needs triage label Apr 24, 2020
@eliserichards eliserichards mentioned this issue Apr 24, 2020
Merged
10 tasks
@eliserichards eliserichards mentioned this issue May 12, 2020
Closed
@eliserichards eliserichards mentioned this issue May 21, 2020
Closed
6 tasks
@eliserichards eliserichards mentioned this issue Jun 3, 2020
Merged
4 tasks
@liuche liuche mentioned this issue Jun 5, 2020
Closed
4 tasks
@eliserichards eliserichards mentioned this issue Jun 9, 2020
Closed
@eliserichards eliserichards self-assigned this Jun 10, 2020
@eliserichards eliserichards mentioned this issue Jun 10, 2020
Closed
4 tasks
@eliserichards eliserichards added the eng:qa:needed QA Needed label Jun 10, 2020
@AndiAJ
Copy link
Collaborator

AndiAJ commented Jun 22, 2020

Hi, verified as fixed on the latest Nightly Build 200622 from 6/22 using the following devices:
• Google Pixel 3a (Android 10)
• Huawei Mate 20 Lite (Android 9)
• OnePlus A3 (Android 6.0.1)

✔️ Username can be empty/null
✔️ Password cannot be empty/null
✔️ Open keyboard when clicking into editable text fields (this should work)

► Screenshot
rsz_img_20200622_104507

@AndiAJ AndiAJ closed this as completed Jun 22, 2020
@AndiAJ AndiAJ removed the eng:qa:needed QA Needed label Jun 22, 2020
@AndiAJ AndiAJ added the eng:qa:verified QA Verified label Jun 22, 2020
@AndiAJ AndiAJ mentioned this issue Jun 22, 2020
Closed
@data-sync-user data-sync-user changed the title Error states for saved logins FNX2-15775 ⁃ Error states for saved logins Jul 30, 2020
@data-sync-user data-sync-user changed the title FNX2-15775 ⁃ Error states for saved logins FNX3-13699 ⁃ Error states for saved logins Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX3-13699 ⁃ Error states for saved logins FNX-3335 ⁃ Error states for saved logins Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX-3335 ⁃ Error states for saved logins FNX2-15775 ⁃ Error states for saved logins Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX2-15775 ⁃ Error states for saved logins Error states for saved logins May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@eliserichards eliserichards

Labels
E3 Estimation Point: average, 2 - 3 days eng:qa:verified QA Verified Feature:Logins
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eliserichards @AndiAJ @data-sync-user