Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Home screen text should use values associated with wallpapers #26444

Closed
MatthewTighe opened this issue Aug 11, 2022 · 1 comment · Fixed by #26716 or nathanmkaya/fenix#108
Closed

Home screen text should use values associated with wallpapers #26444

MatthewTighe opened this issue Aug 11, 2022 · 1 comment · Fixed by #26716 or nathanmkaya/fenix#108
Assignees
@mcarare
Labels
eng:qa:verified QA Verified Feature:Wallpapers needs:UX-feedback Needs UX Feedback
Milestone
106

Comments

@MatthewTighe
Copy link
Contributor

MatthewTighe commented Aug 11, 2022 •
edited by data-sync-user
Loading

In #26281 we added the ability for the home screen header and link text to react to whether a wallpaper was set.

After #26423 is resolved, there should be metadata available for each individual wallpaper describing whether light text or dark text should be used to overlay the wallpaper. The implementation should be updated to:

  • access the text color property available on the current wallpaper and apply it when the current wallpaper is updated

┆Issue is synchronized with this Jira Task
@github-actions github-actions bot added the needs:triage Issue needs triage label Aug 11, 2022
@MatthewTighe MatthewTighe mentioned this issue Aug 11, 2022
Merged
4 tasks
@MatthewTighe MatthewTighe removed the needs:triage Issue needs triage label Aug 11, 2022
@mcarare mcarare added the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Aug 18, 2022
@mcarare mcarare self-assigned this Aug 24, 2022
mcarare added a commit to mcarare/fenix that referenced this issue Aug 24, 2022
@mcarare
For mozilla-mobile#26444: Add back plating to Pocket Powered by text.
943e60d
mcarare added a commit to mcarare/fenix that referenced this issue Aug 24, 2022
@mcarare
For mozilla-mobile#26444: Use wallpaper adapted color for headers on …
6cb10f0 
…home screen.
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Aug 24, 2022
@github-actions github-actions bot mentioned this issue Aug 24, 2022
Closed
4 tasks
mcarare added a commit to mcarare/fenix that referenced this issue Aug 24, 2022
@mcarare
For mozilla-mobile#26444: Add back plating to Pocket 'Powered by' sec…
2bfe1d1 
…tion.
mcarare added a commit to mcarare/fenix that referenced this issue Aug 24, 2022
@mcarare
For mozilla-mobile#26444: Use wallpaper adapted color for headers on …
842b804 
…home screen.
mcarare added a commit to mcarare/fenix that referenced this issue Aug 24, 2022
@mcarare
For mozilla-mobile#26444: Remove RequiresApi O from Autofill.
772bf91
mcarare added a commit to mcarare/fenix that referenced this issue Aug 25, 2022
@mcarare
For mozilla-mobile#26444: Add back plating to Pocket 'Powered by' sec…
b66a988 
…tion.
mcarare added a commit to mcarare/fenix that referenced this issue Aug 25, 2022
@mcarare
For mozilla-mobile#26444: Use wallpaper adapted color for headers on …
09bb424 
…home screen.
mcarare added a commit to mcarare/fenix that referenced this issue Aug 25, 2022
@mcarare
For mozilla-mobile#26444: Remove RequiresApi O from Autofill.
adddfb0
mcarare added a commit to mcarare/fenix that referenced this issue Aug 25, 2022
@mcarare
For mozilla-mobile#26444: Use wallpaper adapted color for headers on …
66e8334 
…home screen.
mcarare added a commit to mcarare/fenix that referenced this issue Aug 25, 2022
@mcarare
For mozilla-mobile#26444: Remove RequiresApi O from Autofill.
9194f8d
mcarare added a commit to mcarare/fenix that referenced this issue Aug 25, 2022
@mcarare
For mozilla-mobile#26444: Adapt Pocket 'powered by' text to wallpaper.
504e0d6
mcarare added a commit to mcarare/fenix that referenced this issue Aug 29, 2022
@mcarare
For mozilla-mobile#26444: Use wallpaper adapted color for headers on …
0498035 
…home screen.
mcarare added a commit to mcarare/fenix that referenced this issue Aug 29, 2022
@mcarare
For mozilla-mobile#26444: Adapt Pocket 'powered by' text to wallpaper.
0edc9fa
mcarare added a commit to mcarare/fenix that referenced this issue Aug 29, 2022
@mcarare
For mozilla-mobile#26444: Use wallpaper adapted color for headers on …
7922480 
…home screen.
mcarare added a commit to mcarare/fenix that referenced this issue Aug 29, 2022
@mcarare
For mozilla-mobile#26444: Adapt Pocket 'powered by' text to wallpaper.
a189c7a
mcarare added a commit to mcarare/fenix that referenced this issue Aug 29, 2022
@mcarare
For mozilla-mobile#26444: Use wallpaper adapted color for headers on …
8f39bc2 
…home screen.
mcarare added a commit to mcarare/fenix that referenced this issue Aug 29, 2022
@mcarare
For mozilla-mobile#26444: Adapt Pocket 'powered by' text to wallpaper.
5bc39b1
mcarare added a commit to mcarare/fenix that referenced this issue Aug 29, 2022
@mcarare
For mozilla-mobile#26444: Use wallpaper adapted color for headers on …
0fde61d 
…home screen.
mcarare added a commit to mcarare/fenix that referenced this issue Aug 29, 2022
@mcarare
For mozilla-mobile#26444: Adapt Pocket 'powered by' text to wallpaper.
3db400d
mcarare added a commit to mcarare/fenix that referenced this issue Aug 30, 2022
@mcarare
For mozilla-mobile#26444: Use wallpaper adapted color for headers on …
15187ba 
…home screen.
mcarare added a commit to mcarare/fenix that referenced this issue Aug 30, 2022
@mcarare
For mozilla-mobile#26444: Adapt Pocket 'powered by' text to wallpaper.
38e878d
mcarare added a commit to mcarare/fenix that referenced this issue Aug 30, 2022
@mcarare
For mozilla-mobile#26444: Use wallpaper adapted color for headers on …
8183629 
…home screen.
mcarare added a commit to mcarare/fenix that referenced this issue Aug 31, 2022
@mcarare
For mozilla-mobile#26444: Replace SectionHeader with HomeSectionHeade…
bccec0d 
…r for home sections.
mcarare added a commit to mcarare/fenix that referenced this issue Aug 31, 2022
@mcarare
For mozilla-mobile#26444: Adapt HomeSectionHeader text colors to wall…
64599d4 
…paper.
mcarare added a commit to mcarare/fenix that referenced this issue Aug 31, 2022
@mcarare
For mozilla-mobile#26444: Adapt Pocket 'powered by' text to wallpaper.
bc26cd9
mcarare added a commit to mcarare/fenix that referenced this issue Aug 31, 2022
@mcarare
For mozilla-mobile#26444: Adapt Pocket 'powered by' text to wallpaper.
a6bb03a
mcarare added a commit to mcarare/fenix that referenced this issue Aug 31, 2022
@mcarare
For mozilla-mobile#26444: Replace SectionHeader with HomeSectionHeade…
affe51f 
…r for home sections.
mcarare added a commit to mcarare/fenix that referenced this issue Aug 31, 2022
@mcarare
For mozilla-mobile#26444: Adapt HomeSectionHeader text colors to wall…
e5f9808 
…paper.
mcarare added a commit to mcarare/fenix that referenced this issue Aug 31, 2022
@mcarare
For mozilla-mobile#26444: Adapt Pocket 'powered by' text to wallpaper.
3ca16ae
mcarare added a commit to mcarare/fenix that referenced this issue Aug 31, 2022
@mcarare
For mozilla-mobile#26444: Refactor HomeSectionHeader to have optional…
726e267 
… show all text.
mcarare added a commit to mcarare/fenix that referenced this issue Aug 31, 2022
@mcarare
For mozilla-mobile#26444: Replace SectionHeader with HomeSectionHeade…
e0ba660 
…r for home sections.
mcarare added a commit to mcarare/fenix that referenced this issue Aug 31, 2022
@mcarare
For mozilla-mobile#26444: Adapt HomeSectionHeader text colors to wall…
a0d4f5b 
…paper.
mcarare added a commit to mcarare/fenix that referenced this issue Aug 31, 2022
@mcarare
For mozilla-mobile#26444: Adapt Pocket 'powered by' text to wallpaper.
4822de2
@mergify mergify bot closed this as completed in #26716 Aug 31, 2022
mergify bot pushed a commit that referenced this issue Aug 31, 2022
@mcarare @mergify
For #26444: Refactor HomeSectionHeader to have optional show all text.
8a599bb
mergify bot pushed a commit that referenced this issue Aug 31, 2022
@mcarare @mergify
For #26444: Replace SectionHeader with HomeSectionHeader for home sec…
02be760 
…tions.
mergify bot pushed a commit that referenced this issue Aug 31, 2022
@mcarare @mergify
For #26444: Adapt HomeSectionHeader text colors to wallpaper.
186dee7
mergify bot pushed a commit that referenced this issue Aug 31, 2022
@mcarare @mergify
For #26444: Adapt Pocket 'powered by' text to wallpaper.
7cbe730
@github-actions github-actions bot added this to the 106 milestone Aug 31, 2022
@github-actions github-actions bot reopened this Aug 31, 2022
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Aug 31, 2022
@mcarare mcarare added eng:qa:needed QA Needed and removed eng:qa:needed QA Needed 🙅 waiting Issues that are blocked or has dependencies that are not ready labels Sep 1, 2022
@delia-pop
Copy link

Verified as fixed with latest Debug build updated from main. We will re-test this on Nightly when available.
Tagging UX to confirm this is the expected design.

Debug WAllpaper

@delia-pop delia-pop added eng:qa:verified QA Verified needs:UX-feedback Needs UX Feedback and removed eng:qa:needed QA Needed labels Sep 1, 2022
@Mugurell Mugurell mentioned this issue Sep 6, 2022
Closed
@github-actions github-actions bot mentioned this issue Sep 27, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mcarare mcarare

Labels
eng:qa:verified QA Verified Feature:Wallpapers needs:UX-feedback Needs UX Feedback
Projects
None yet
Milestone
106
3 participants
@MatthewTighe @mcarare @delia-pop