Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Simplify wallpaper types and download metadata about them from the remote source. #26423

Closed
MatthewTighe opened this issue Aug 10, 2022 · 0 comments · Fixed by #26479, #26499 or nathanmkaya/fenix#108

Comments

@MatthewTighe
Copy link
Contributor

MatthewTighe commented Aug 10, 2022

We are planning to remove the wallpapers shipped with Firefox to our remote source. Because of that, there will no longer be a need to distinguish between local and remote wallpapers. The only special case will be the default wallpaper, which does not have an asset.

AC:

  • remove explicit references to individual wallpapers
  • remove distinction between Wallpaper.Local and Wallpaper.Remote
  • the Expired and Promotional types can also be removed and will be replaced by metadata
  • download metadata as JSON from the remote source and unmarshal it into wallpaper objects directly
  • the above may require slight updates to the wallpaper URL, as the metadata will be shared between iOS and Android and the current path references the android path specifically. this would require updating the secret in CI as well. it may also be possible to link the metadata into a child directory on the remote host, which would probably be more straightforward

┆Issue is synchronized with this Jira Task

@github-actions github-actions bot added the needs:triage Issue needs triage label Aug 10, 2022
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Aug 15, 2022
@mergify mergify bot closed this as completed in #26479 Aug 16, 2022
@github-actions github-actions bot reopened this Aug 16, 2022
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Aug 16, 2022
@github-actions github-actions bot added this to the 105 milestone Aug 16, 2022
@MatthewTighe MatthewTighe removed eng:qa:needed QA Needed needs:triage Issue needs triage labels Aug 16, 2022
MatthewTighe added a commit to MatthewTighe/fenix that referenced this issue Aug 16, 2022
MatthewTighe added a commit to MatthewTighe/fenix that referenced this issue Aug 16, 2022
MatthewTighe added a commit to MatthewTighe/fenix that referenced this issue Aug 16, 2022
MatthewTighe added a commit to MatthewTighe/fenix that referenced this issue Aug 17, 2022
MatthewTighe added a commit to MatthewTighe/fenix that referenced this issue Aug 17, 2022
MatthewTighe added a commit to MatthewTighe/fenix that referenced this issue Aug 17, 2022
MatthewTighe added a commit to MatthewTighe/fenix that referenced this issue Aug 17, 2022
MatthewTighe added a commit to MatthewTighe/fenix that referenced this issue Aug 17, 2022
MatthewTighe added a commit to MatthewTighe/fenix that referenced this issue Aug 17, 2022
@mergify mergify bot closed this as completed in #26499 Aug 18, 2022
mergify bot pushed a commit that referenced this issue Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.