Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug]: Autofill does not work on another apps #23707

Closed
Disil opened this issue Feb 13, 2022 · 45 comments
Closed

[Bug]: Autofill does not work on another apps #23707

Disil opened this issue Feb 13, 2022 · 45 comments
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Logins Needs-UX Issues or tickets that need UX input or review qa-triaged Issues triaged by qa

Comments

@Disil
Copy link

Disil commented Feb 13, 2022

Steps to reproduce

  1. Enable 'autofill in other apps' option in settings.
  2. Go into a website, fill the log in form, and firefox will offers to save the password (Of course we need to save them so autofill work)
  3. Go into another apps (in this case will be samsung internet)
  4. Go to the same website that you already 'saved the password'.
  5. Press on the log in form

Expected behaviour

An autofill menu should open or pop up to choose the credential

Actual behaviour

Nothing, but in Samsung Keyboard there is button that says 'Unlock Firefox Beta' with fingerprint icon. When it is pressed, nothing happened.

Device name

Samsung Galaxy A10s

Android version

Android 11

Firefox release type

Firefox Beta

Firefox version

98.0.0-beta.1

Device logs

No response

Additional information

Screenshot_20220213-205548_Via
This is how the 'unlock firefox beta' button appeared. Notice how it is appeared in keyboard, and have a fingerprint icon on it. I don't have any kind of lock screen in this device.

┆Issue is synchronized with this Jira Task

@Disil Disil added needs:triage Issue needs triage 🐞 bug Crashes, Something isn't working, .. labels Feb 13, 2022
@amedyne amedyne added Feature:Logins eng:qa:needed QA Needed and removed needs:triage Issue needs triage labels Feb 14, 2022
@SoftVision-LorandJanos
Copy link

Hi @Disil ! Thank you for your report!
I can confirm that your issue is reproducible.
The same "Unlock Firefox Beta" and "Unlock Firefox Nightly" (for Nightly) is displayed with no function on tapping.
Tested with the latest Nightly 99.0a1 (2022-02-15) and latest Beta (98.0.0-beta1).
Device used: Oppo Reno 6 (Android 11).

@SoftVision-LorandJanos SoftVision-LorandJanos added qa-triaged Issues triaged by qa and removed eng:qa:needed QA Needed labels Feb 15, 2022
@Alexandru2909
Copy link
Contributor

Hi @Disil , since you mentioned that you don't have any screen lock type set up, the issue seems to be that we don't handle this case. Tagging UX to check how should we deal with the case when the user wants to use Autofill in other apps but no screen lock type is set.

@Alexandru2909 Alexandru2909 added the Needs-UX Issues or tickets that need UX input or review label Feb 18, 2022
@Alexandru2909 Alexandru2909 self-assigned this Feb 18, 2022
@Disil
Copy link
Author

Disil commented Feb 18, 2022

I set up a password, and it still doesnt work. It ask me to enter my pin, and then there is 'Search firefox beta' button appear. When i clicked on them, nothing happened.

@KazaHesto
Copy link

I also have this issue, and have a lock screen enabled. Seems to only affect Nightly and Beta, Release has no issues

@Juriyx
Copy link

Juriyx commented Mar 9, 2022

Hi. I confirm this issue on all versions - the latest stable version (97.3.0), Beta (98.0.0-beta.4) and Nightly (100.0a1).
A button with fingerprint icon and "Unlock Firefox" text appears at the top of Gboard keyboard, I click on it and nothing happens. Touch to fingerprint on the right side of my smartphone (Poco F3) also doesn't give anything.
PIN code is set and fingerprints are added.

MIUI 12.5.6.0, Android 11

@Juriyx
Copy link

Juriyx commented Mar 9, 2022

My proposition is to fix this bug or remove the app's request for fingerprint, because device is already unlocked!

@Juriyx
Copy link

Juriyx commented Mar 10, 2022

Temporary solution is to use the Firefox Lockwise app. Yes, its support ended but it works as expected and I think that everyone, who wants, can use it until the bug will be fixed. Can be downloaded from reliable sites like APKPure

@bananer
Copy link

bananer commented Mar 10, 2022

For me it was not working with Firefox Nightly but fixed after moving to stable.

@KazaHesto
Copy link

Stable recently updated for me and that broke it
Annoying since I moved to stable to fix this

@Juriyx
Copy link

Juriyx commented Mar 10, 2022

For me it was not working with Firefox Nightly but fixed after moving to stable.

I do not argue with you, but on my configuration, autocomplete does not work with any version of Firefox

@KazaHesto
Copy link

For me it was not working with Firefox Nightly but fixed after moving to stable.

I do not argue with you, but on my configuration, autocomplete does not work with any version of Firefox

I didn't note down what version my stable was at, it's possible it was older than you tested? I'm using a Samsung Galaxy S21, Android 12, and the broken version of stable it just updated to is 98.1.1

@Juriyx
Copy link

Juriyx commented Mar 10, 2022

it's possible it was older than you tested?

Maybe

@KazaHesto
Copy link

KazaHesto commented Mar 11, 2022

Using builds from https://archive.mozilla.org/pub/fenix/nightly/ , the first bad build appears to be:

98.0a1 (Build #2015862031), bae20d6+
AC: 98.0.20220207143129, ec0201897a
GV: 98.0a1-20220206065831
AS: 91.0.1

2022-02-07T17:11:19.529657

Suspecting mozilla-mobile/android-components@ec02018 since nothing else looks relevant in the range between the last good and first bad build

@KazaHesto
Copy link

Filed #24199 since this issue seems initially focused on when there is no lock screen set up

@bananer
Copy link

bananer commented Mar 11, 2022

Just installed the update for Firefox stable and autofill stopped opening from other apps as well for me.

Was working on: 97.3.0 (Build #2015866875), aeec125+
AC: 97.0.13, 0465a6f809
GV: 97.0.2-20220304162637
AS: 87.1.0

Broken on: 98.1.1 (Build #2015866891), a44eb55+
AC: 98.0.11, 2250f94195
GV: 98.0-20220304153049
AS: 91.0.1

@amedyne
Copy link
Contributor

amedyne commented Mar 14, 2022

@Mugurell Can you check and validate if the changes referred to here #23707 (comment) is the cause?

@Disil
Copy link
Author

Disil commented Mar 16, 2022

The 'unlock firefox beta' button has completely disappeared in the latest beta updates,
99.0.0-beta.2 (Build #2015868713), 7758954+
AC: 99.0.2, 3bb1385eee
GV: 99.0-20220313185831
AS: 91.1.0

@bananer
Copy link

bananer commented Mar 17, 2022

I can confirm it's fixed in Nightly 100.0a1 (Build #2015869227)

@Alexandru2909 Alexandru2909 removed their assignment Mar 17, 2022
@Juriyx
Copy link

Juriyx commented Mar 17, 2022

The 'unlock firefox beta' button has completely disappeared in the latest beta updates,
99.0.0-beta.2

On my Poco F3, there is no such change

@Juriyx
Copy link

Juriyx commented Mar 17, 2022

I can confirm it's fixed in Nightly 100.0a1 (Build #2015869227)

No changes, at least on my Poco F3

@Mugurell
Copy link
Contributor

@Disil @Juriyx After #24199 one particular scenario should be fixed - that selected logins are actually autofilled.

If there are other issues we'd need complete steps to reproduce (including the login url / app in which login is not autofilled and a video) to be able to investigate the same exact scenario.

Regarding the scenario described for this ticket - #23707 (comment) I now tested on Fenix v97 (before the regression now fixed in #24199) and saw there also that indeed autofill does not work in Samsung Browser. Neither in Chrome. So in this case indeed the fix from #24199 would not help.
I remember #21942 (comment) about how our functionality is not compatible with Chrome, it seems to be the same with Samsung Browser (which is based on Chromium).

@Mugurell
Copy link
Contributor

At a quick search it seems that other users are also reporting that autofill may have issues in Samsung browser - bitwarden/mobile#1277

@Mugurell
Copy link
Contributor

Regarding Samsung Browser in particular it seems there is a whitelist of apps that can autofill - bitwarden/mobile#895 (comment)

@Juriyx
Copy link

Juriyx commented Mar 17, 2022

one particular scenario should be fixed - that selected logins are actually autofilled.

As I wrote earlier, I didn't get to this step, because tap on the button "Unlock Firefox" does nothing. This is the main problem in my case.
Checked in TeamViewer app, for example, but it doesn't matter which app I choose to test.

P. S. I thought that this topic is about entering passwords in other applications, but I have no need to enter passwords using Firefox in other browsers. This is some strange scenario 😀 (IMHO)

@Disil
Copy link
Author

Disil commented Mar 17, 2022

P. S. I thought that this topic is about entering passwords in other applications, but I have no need to enter passwords using Firefox in other browsers.

Well for users who swapped browsers daily (between Firefox and other browser) this is a problem. I test the autofill again on Via Browser and it shows the Unlock Firefox button, and as always, it does nothing.

@Mugurell
Copy link
Contributor

I'd say from a user standpoint it is reasonable to expect the autofill feature from Fenix to work in any installed apps.
Though because this is a highly complex functionality with multiple apps involved and system features also, it seems like there may be different issues which need to be investigated separately.

I'll take Samsung Browser just as an example of where an autofill issue reproduces and note that for the moment we can't support that.
For reports about "Unlock.." not working I'll need more details to be able to reproduce:

  • device model and android version
  • the current current screen lock set in system settings (we do not currently support "no lock")
  • the 3rd party application in which autofill is tried

@Mugurell
Copy link
Contributor

@Disil If as per the first comment you don't have any screen lock set then at this time autofill is expected to not work - mozilla-mobile/android-components#9756

@Juriyx Is this the same situation for you - no screen lock set?

Would appreciate if just for test you could set another screen lock method and report back.
Just want to understand the exact scenarios we need to fix.

@Disil
Copy link
Author

Disil commented Mar 18, 2022

  • (we do not currently support "no lock")

@Mugurell I set up pin screen lock. And at first I thought it will work, because it ask me to insert my pin. After that there's a button that says "Search Firefox Beta' which is useless. When pressed, it disappear and nothing happens.

  • the 3rd party application in which autofill is tried

I tried it on a bunch of browser, even trying them on Firefox Release and Nightly, it still does nothing.

@Mugurell
Copy link
Contributor

  • (we do not currently support "no lock")

@Mugurell I set up pin screen lock. And at first I thought it will work, because it ask me to insert my pin. After that there's a button that says "Search Firefox Beta' which is useless. When pressed, it disappear and nothing happens.

Can you please try the same scenario in the current Firefox Nightly?

@xatr0z
Copy link

xatr0z commented Mar 18, 2022

I'm experiencing the same problem on a new phone (old one was still using lockwise besides firefox though).

After installing Firefox NIghtly (and switching autofill app to nightly instead of normal firefox);

  • One app which AFAIK didnt work before (Twitter) shows my username, after clicking on it it fills user+password
  • But most apps still have the same issue (ie Nextdoor); sometimes the acounts are visible less then a second after which they disappear and only the Search Firefox Nightly option is available. But clicking this doesnt do anything
  • Other app (nl.ouderportaal.ouderapp) shows an account but gives the old 'Verification failed' popup, no information is autofilled

@Mugurell
Copy link
Contributor

@xatr0z

Other app (nl.ouderportaal.ouderapp) shows an account but gives the old 'Verification failed' popup, no information is autofilled

The "Verification failed" might be expected, it being part of the current functionality as another important step to secure credentials access - mozilla-mobile/android-components#9777, https://github.com/google/digitalassetlinks/blob/master/well-known/details.md
I'd expect other password managers to show a similar dialog when first trying to autofill in that specific app.

Seems like that app need a certain url first entered before the username+password pair so I can't easily test now.
Does clicking "Yes" in the "Verification failed" dialog autofills the credentials?

@xatr0z
Copy link

xatr0z commented Mar 18, 2022

@Mugurell Unfortunately no, after clicking yes nothing happens (same as next door)

For other readers. As suggested elsewhere I'm currently using lockwise so I can reach my passwords without manually looking up each app.

@Juriyx
Copy link

Juriyx commented Mar 18, 2022

Is this the same situation for you - no screen lock set?

Would appreciate if just for test you could set another screen lock method and report back. Just want to understand the exact scenarios we need to fix.

I have a PIN and fingerprints set. I will check with a password only.

@BlindMoon38
Copy link

Came from #24199.

When tapping the Unlock Firefox Nightly button while in a login field, nothing happens. The focus returns to the input field and the Unlock Firefox Nightly button reappears.

As an aside, I use TalkBack as my screen reader.

  • Firefox Nightly 100.0a1 2022-03-18T05:08:55.900797.
  • Xiaomi Redmi Note 8 with MIUI 12.5.1.0, Android 11.
  • TalkBack version 12.1.
  • Apps tested: Twitter, Reddit.
  • Unlocking methods set: pin, fingerprint.

@Juriyx
Copy link

Juriyx commented Mar 19, 2022

The same situation with a password only

@BlindMoon38
Copy link

I managed to get it working thanks to @mike-pt in this #24423 comment.

Sadly, after unlocking, no login suggestions appear. Fortunately, going to another screen in the app, going back to the login screen, and tapping the username field makes a Search Firefox Nightly button appear, and tapping it displays the Firefox's login search UI.

Tested in both Twitter and Reddit.

I'd recommend adding a message to inform users of the possible need to give the Display popup windows while running in the background permission when enabling autofill in other apps in Firefox settings. I wouldn't have known to do it, nor that it is needed in my device or use case.

@plwt
Copy link

plwt commented Jul 21, 2022

@hien4990
Copy link

me not work either i tested with tecnopova 2 and lenovo tab m10 gen 3

@Antorell
Copy link

Firefox's autofill doesn't work, still. I'm using it on a Xiaomi Redmi 11 note NFC with Android 11 Using Firefox 107.1.0 or the current Android Beta. It asks for a fingerprint to unlock Firefox that doesn't do anything. And there's no visible option to disable the fingerprint to unlock security measure. Otherwise the autofill works fine with Microsoft Authenticator, Edge or Google Chrome.

@Mugurell
Copy link
Contributor

Mugurell commented Jan 12, 2023

The above reports are a bit old.
For everyone who still sees this issues: can you please add here

  • the Firefox version used
  • the keyboard used
  • the device used: model and Android version
  • in which 3rd party application you are trying to autofill?
  • a video of the exact scenario would also be great.

Testing this for myself I saw that:

  • On a Samsung S7 with Android 8 autofill popup for Fenix / Google or Bitwarden.
  • On both:
    • OnePlus 7 with Android 11 and the GBoard keyboard
    • Pixel 7 with Android 13 and the GBoard keyboard
      the inline autofill does work as expected:
AutofillInTwitter.mov

@Antorell
Copy link

Antorell commented Jan 12, 2023

Firefox doesn't ask to save passwords in android app when it's set as default Autofill on my phone.

I just tested it right now as I wrote the reply on:
Firefox Android 108.2.0
Microsoft Swiftkey Keyboard
Redmi Note 11 NFC (EU version V13.0.2.0.SGKEUXM) - MIUI 13 with Android 12
Casino Max/Carrefour App

I use Microsoft Authenticator to Autofill, I've also used Chromium Edge for Android. Both don't have any issue to suggest passwords in app, and they both ask to save passwords when I enter a password that's not in the list of saved site/apps password.

edit: I clicked on the fingerprint to unlock Firefox's password manager/autofill when asked when I typed the email and password in the app.

@delia-pop
Copy link

delia-pop commented Jan 13, 2023

Tested on the latest Nightly 110.0a1 from 01/13 with Xiaomi Redmi Note 8T (Android 11). I was able to log in to Twitter without issues using the saved logins from Fenix. Both passcode and fingerprint unlocking methods were used.

Screenrecorder-2023-01-13-17-29-46-960.mp4

@SoftVision-LorandJanos
Copy link

SoftVision-LorandJanos commented Jan 16, 2023

I couldn't reproduce the issue on the latest nightly 110.0a1 (2023-01-16) and on RC 108.2.0 builds, using a Xiaomi Mi11 Lite (Android 11).
I've tried reproducing the issue with Gboard and Swiftkey as well.
Autofill worked as expected.

@Mugurell
Copy link
Contributor

Thank you all for the reports!
Looks like this issue was resolved based on the above reports and the ones from #24199 with mozilla-mobile/android-components#11893 fixing an issue with autofill not working immediately after unlocking Firefox from the keyboard and as such I will close this ticket.

@Mugurell
Copy link
Contributor

For the scenario from #23707 (comment) - Firefox recognizing user entered credentials in other apps @Antorell please open a new ticket showcasing the functionality present in other applications.
Note that Firefox will recognize credentials entered when browsing with Firefox and Microsoft Edge might do the same but I am not sure that a password manager can recognize credentials being entered in a third party application to offer to remember them.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. Feature:Logins Needs-UX Issues or tickets that need UX input or review qa-triaged Issues triaged by qa
Projects
None yet
Development

No branches or pull requests