-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Auto-fill doesn't work on Samsung browser Stable and Beta. #895
Comments
Samsung released an updated browser beta today which properly allows both the autofill service and our autofill accessibility service to function. |
I can't make it work automatic filling
|
Autofill also doesn't work for me, I have latest Bitwarden and tried on latest S Browser Beta |
Hello |
It's good it works, THANKS: +1: for me it works with Bitwarden 2.3.1 official version, without beta version |
It's also available on the Play Store as a separate installation: https://play.google.com/store/apps/details?id=com.sec.android.app.sbrowser.beta |
do you have a link for Bitwarden in beta version? I can't find it |
For Bitwarden use the 'join beta' button on our Play Store page and your existing installation will be upgraded. |
@mportune-bw I also tried v11.1.2.2 but it also doesn't work |
@the4anoni It definitely requires the newer v12.x.x.x release, but unfortunately I'm not sure why that isn't even working for you when it works for others (as well as myself). Maybe something else on your device is interfering with autofill and/or accessibility? |
Auto fill works on chrome |
Did you check the settings in v12? |
Tried with this enabled/disabled and still not working on latest beta for both apps. |
I'm at a loss. I'll keep an eye out for any clues as to why it's not working for you, but for the moment... /shrug |
I had enabled this, but auto fill still doesn't work. |
I have the same problem, autofill doesn`t work in Samsung Internet. Tried enable/disable some options in Setting and still not working. Autofill works in Edge and Chrome on same device. Bitwarden Beta 2.3.1 (2413) |
@mportune-bw can you re-open issue? |
With me it works Conditions for it to work
|
Can you give one example site on which auto fill works? |
Doesn't work for me, tried on last SBrowser beta and Bitwarden last beta. |
Sbrowser beta 12.0.1.36 and bitwarden 2.4.3, autofill still doesn't work @mportune-bw |
Working fine here |
It doesn't work fine. For example google account sign in. I would suggest to implement a keyboard for such cases. |
@the4anoni clicking on that fills password not email address. |
Only on google.com, on github it works ok. Also on chrome I've noticed this same bug. |
@yurividal Fwiw we show a different icon for Accessibility (black & white shield, vs blue for Autofill) for exactly this purpose. It was becoming nearly impossible to troubleshoot when users had both enabled and they were visually identical. |
Could you give us a "beta" version that has a forged package name until Samsung has finally fixed this? |
You'd think Samsung would want to gain market share for their mobile browser. 🤔 |
That would be a bad idea for lots of reasons that are beyond the scope of this issue. :) |
Is there anything that we can do to help get their attention? Is there no way to get in contact with an engineer that maintains the Samsung Browser? Surely there is some channel for communication, or someone with contacts within Samsung? From what I understand it works fine with other password managers. Would a smaller company like AgileBits be willing to provide insight on this issue? I know they're Bitwarden's competition, but it would be nice for someone to help for the "greater good" of providing a safe and secure web. |
@mportune-bw Sorry, I forgot to add some irony, don't take this too seriously! ;) |
@Phangan Understood, lol :) So I just updated to Samsung Internet 14 stable, and Autofill is working and even supports inline via the Samsung keyboard. Both of these things are something I never expected to see. Anybody else? (I'm on an S10 w/ Android 11) |
@mportune-bw as you can see in the version numbering here: #895 (comment) I've been rocking 14 stable but experience the bug. So annoying. The dev has it all working and users have issues xD |
@Tosko4 Bummer, mine is the same browser build. The only difference is I'm running an internal build of Bitwarden (2.9.2) but I don't believe anything autofill related has been touched since 2.9.1. Hopefully I can get a beta out relatively soon in case i'm wrong. |
It doesn't work for me at all. Only the accessibility service works for me. Samsung Internet v14.0.1.62 |
Just confirming - has everyone disabled the browser's built-in autofill settings in Internet Settings > Personal Data > Autofill forms (and the two switches in Usernames and passwords)? |
Yes, I disabled all of those settings a long time ago and I just confirmed that they are still disabled. Thanks again for trying to help. Samsung DeX mode on their latest tablets is really awesome and the DeX experience in the browser is also great. I just can't bring myself to use the browser without proper support for Bitwarden. |
Yep. All disabled |
The above solution works here. |
Same build here. In-line autofill does "work", but, as stated before, it only works sometimes. In many occasions bitwarden does not recognize the website (it either identifies the website as being "--" or being "com.sec.android.app.sbrowser.beta") so you have to manually search for the site in bitwarden. Then, clicking the correct site, it also only actually fills in sometimes. |
From what I can see of the curent behaviour of the Bitwarden app, it seems to have been added to this 'whitelist'. Would you mind sharing how you managed to fix this in the end? I am running into the same issue with my own project. |
The weirdest thing is that, if you close Samsung browser (recents, swipe up) and relaunch it, bitwarden works and you get the inline autofill. It works for a while, and then after some minutes it stops again. So, it's definitely some sort of timer or timeout that is going on, that somehow kills the autofill service for the browser. |
@yurividal So if I understand correctly, you still have problems with the Bitwarden autofill service in combination with the Samsung browser? I did some tests today of both the accessibility service and the autofill service with the browser, and they functioned as they should for at least 15 minutes (as long as I ran the tests) so the problem seems fixed on my end (most recent versions of Bitwarden and the Samsung browser) |
@mdvmeijer Only the accessibility service prompt pops up, and once in a while even that fails. Samsung Galaxy S21 Ultra running Android 11 w/ One UI 3.1 |
Accessibility is completely disabled, to make sure I'm using autofill API. Autofill works with Samsung Browser only sometimes. It's like if the service has some sort of timeout. If you kill the browser (swipe up from recent) and relaunch the browser on the same page, autofill will work. |
It can also be related to turning the screen off, instead of an actual timeout. |
@mdvmeijer this video shows exactly what I mean: |
I see, it indeed seems like there is still something interfering with the autofill service. @mportune-bw Could you maybe shed some light on this or is this still a mystery to the team? |
I have the same issue as @yurividal , i mentioned this before in a previous comment. But I'd like to point out something. Might help troubleshooting, because we might be looking in the wrong area. It's not just Samsung Browser related. Other browsers have same issue with bitwarden, exactly the same as recorded in @yurividal his video. Such as, chrome, brave etc. Sometimes bitwarden recognizes the login field and shows the bitwarden button to fill in credentials. Other times it doesn't, I close the browser, reopen the browser and voila, bitwarden button is shown. I believe the issue is not a compatibility problem with a specific browser, or a whitelisting issue, but more fundamental. On my iOS devices I don't have issues with bitwarden, only on Android devices. @MattTheDev |
@Tosko4 True, this sounds like a more fundamental problem separate from the whitelisting stuff. I can confirm from my own testing that this whitelist does exist however, and somehow Bitwarden managed to get on it (maybe someone at the Samsung browser dev team really likes Bitwarden :p). If someone on the Bitwarden team has any idea how you managed this then I'd love to hear it. |
@mdvmeijer Based on the power consumption used by accessibility (the event stream can be insane depending on the app) I would guess they stop emitting events unless an app is configured to receive them. I don't know this for sure, however. @Tosko4 I would love to know the answer to this as well, since debugging shows our autofill service alive and well but simply no longer receiving events from the system. @mdvmeijer We've tried to contact them in the past to get whitelisted but never heard anything back. Maybe they finally added us. |
@mportune-bw I tried putting the apps related to each other (Brave, Bitwarden, Chrome, Samsung Browser) in a never deep sleep mode. The new power management on android creates a lot of issues so to say. Not sure if you were referring to that? I'd have no clue how I could help any further honestly. If theres anything I can provide, let me know |
I've excluded these apps from deep sleep as well and still have more issues with Samsung Internet than other Chromium based browser. Honestly, why is autofill such a nightmare in Android? It's been a buggy mess for so long now. |
@douglasparker i think the reason why its a mess is because it depends on a proper and precise implementation from Browsers, Keyboards, and Password Providers. 3 different players have to work together to have it work properly. No wonder why the only proper implementation is on pixel phones using Chrome, GBoard and Google Password Manager. |
@mportune-bw Thank you for your reply. Do you know which channel was used to try to contact them? Then I will try my luck as well. |
Describe the Bug
Like in topic
Steps To Reproduce
Try to login via auto-fill on Samsung browser.
Expected Result
Bitwarden auto-fill suggest you to fill passwords.
Actual Result
There isn't suggestion to auto-fill login and password
Screenshots or Video
Environment
The text was updated successfully, but these errors were encountered: