Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] maps.google.com icon is not displayed on Settings-Site permissions-Exceptions #1919

Closed
lobontiumira opened this issue Apr 23, 2019 · 8 comments
Closed

[Bug] maps.google.com icon is not displayed on Settings-Site permissions-Exceptions #1919

lobontiumira opened this issue Apr 23, 2019 · 8 comments
Assignees
@Amejia481
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:SitePermissions needs:ac Needs Android Component Work P1 Current sprint
Milestone
1.1 Backlog

Comments

@lobontiumira
Copy link

lobontiumira commented Apr 23, 2019 •
edited by data-sync-user
Loading

Steps to reproduce

  1. Go to maps.google.com.
  2. Allow access to location.
  3. Go to Settings > Site permissions > Exceptions and observe the icon.

Expected behavior

The page from step 1 should have a favicon displayed.

Actual behavior

The icon displayed is a green square with a with "W" letter, no matter which site is in the exceptions.

Device information

  • Android device: Google Pixel (Android 9), Samsung Galaxy Tab S3 (Android 8), Nexus 6 (Android 7.1.1)
  • Fenix version: 1.0.1917 (Build#11121210)

Note:

Based on #188 the favicons should be displayed.

Untitled

┆Issue is synchronized with this Jira Task
@lobontiumira lobontiumira added the 🐞 bug Crashes, Something isn't working, .. label Apr 23, 2019
@vesta0 vesta0 added the P1 Current sprint label Apr 23, 2019
@vesta0 vesta0 added this to the MVP Backlog milestone Apr 23, 2019
@cpeterso
Copy link

AC needs to extract website icons from the page: mozilla-mobile/android-components#2080

@vesta0 vesta0 added needs:ac Needs Android Component Work 🙅 waiting Issues that are blocked or has dependencies that are not ready labels Apr 23, 2019
@vesta0 vesta0 modified the milestones: MVP Backlog, Bugs Apr 24, 2019
@vesta0 vesta0 added eng:qa:needed QA Needed and removed 🙅 waiting Issues that are blocked or has dependencies that are not ready labels May 24, 2019
@abodea
Copy link
Member

abodea commented May 28, 2019 •
edited
Loading

The issue still reproduces, exactly like in the description.
Tested on the latest build 1.0.1922 (#build11480607) 28/5, with Samsung Galaxy Note 9(Android 8.1.0) and Google Pixel 3(Android 9).

@abodea abodea removed the eng:qa:needed QA Needed label May 28, 2019
@Amejia481 Amejia481 self-assigned this May 28, 2019
@Amejia481 Amejia481 removed their assignment May 28, 2019
@bifleming bifleming added Release Blocker Blocks a Release and removed P1 Current sprint labels May 30, 2019
@Amejia481 Amejia481 self-assigned this May 30, 2019
Amejia481 added a commit to Amejia481/fenix that referenced this issue May 31, 2019
@Amejia481
For mozilla-mobile#1919- Websites' icons are not displayed on Site pe…
9334ba4 
…rmissions

Exceptions.
colintheshots pushed a commit that referenced this issue May 31, 2019
@Amejia481 @colintheshots
For #1919- Websites' icons are not displayed on Site permissions (#3050)
038aecc 
Exceptions.
@Amejia481
Copy link
Contributor

Be aware, that some sites like maps.google.com their icons are not showing even on the home page, but other website like https://permission.site/ and https://www.mapquest.com/ are showing properly. I don't know if we have a issue for that.

Screenshot_20190531-175834

image

@Amejia481 Amejia481 added the eng:qa:needed QA Needed label May 31, 2019
@vesta0 vesta0 added P1 Current sprint 🙅 waiting Issues that are blocked or has dependencies that are not ready and removed P2 Upcoming release labels Jun 25, 2019
@Amejia481 Amejia481 removed the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Jun 29, 2019
@Amejia481 Amejia481 added the eng:qa:needed QA Needed label Jun 29, 2019
@Amejia481
Copy link
Contributor

This was fixed by mozilla-mobile/android-components@05fed19

@abodea
Copy link
Member

abodea commented Jul 1, 2019

I can still reproduce this issue on the latest build 6/28(1.0.1926(Build #11791805 68.0-20190612114833)) with Samsung Galaxy Note 9(A 8.1.0).
Please note that not even permission.site icon is displayed.
I tried with android 5, 6, 7, 8, 9.
Screenshot_20190701-144252_Firefox Preview
Also, for maps.google.com I was able to reproduce #3795

@abodea abodea added in progress and removed eng:qa:needed QA Needed labels Jul 1, 2019
@abodea
Copy link
Member

abodea commented Jul 3, 2019

Verified as fixed on the latest build from 7/3 with Samsung Galaxy Note 9(Android 8.1.0).
The google Icon is displayed accordingly.

@abodea abodea closed this as completed Jul 3, 2019
@abodea abodea added eng:qa:verified QA Verified and removed in progress labels Jul 3, 2019
@data-sync-user data-sync-user changed the title [Bug] maps.google.com icon is not displayed on Settings-Site permissions-Exceptions FNX2-17505 ⁃ [Bug] maps.google.com icon is not displayed on Settings-Site permissions-Exceptions Aug 4, 2020
@data-sync-user data-sync-user changed the title FNX2-17505 ⁃ [Bug] maps.google.com icon is not displayed on Settings-Site permissions-Exceptions FNX3-15914 ⁃ [Bug] maps.google.com icon is not displayed on Settings-Site permissions-Exceptions Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-15914 ⁃ [Bug] maps.google.com icon is not displayed on Settings-Site permissions-Exceptions FNX-5334 ⁃ [Bug] maps.google.com icon is not displayed on Settings-Site permissions-Exceptions Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-5334 ⁃ [Bug] maps.google.com icon is not displayed on Settings-Site permissions-Exceptions [Bug] maps.google.com icon is not displayed on Settings-Site permissions-Exceptions May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Amejia481 Amejia481

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:SitePermissions needs:ac Needs Android Component Work P1 Current sprint
Projects
None yet
Milestone
1.1 Backlog
Development

No branches or pull requests
9 participants
@pocmo @kbrosnan @cpeterso @Amejia481 @lobontiumira @vesta0 @abodea @bifleming @data-sync-user