Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Extract website icon resources via WebExtension #2080

Closed
pocmo opened this issue Feb 15, 2019 · 5 comments
Closed

Extract website icon resources via WebExtension #2080

pocmo opened this issue Feb 15, 2019 · 5 comments
Assignees
@pocmo
Labels
🌟 feature New functionality and improvements 🐉 Fenix Feature needed for Fenix <icons> Components: ui-icons, browser-icons needs:gv To implement/fix this we need a new API in GeckoView P1
Milestone
0.52.0 🥖

Comments

@pocmo
Copy link
Contributor

pocmo commented Feb 15, 2019 •
edited by data-sync-user
Loading

Currently the GeckoView prefers to not add any icon related APIs. Instead the suggestion is to use the WebExtension API (Bug 1518841) and the Messaging API (Bug 1518843) to add this functionality.

For our icon pipeline we'd need:

  • Favicon URL(s)
  • Touch icon URL(s)
  • Potentially other icons linked in markup.
  • In addition to the URLs we also use (if in markup): size and MIME type.

┆Issue is synchronized with this Jira Task
@pocmo pocmo added 🌟 feature New functionality and improvements <icons> Components: ui-icons, browser-icons labels Feb 15, 2019
@pocmo pocmo changed the title Extract website icon resources Extract website icon resources via WebExtension Feb 15, 2019
@pocmo pocmo added the needs:gv To implement/fix this we need a new API in GeckoView label Feb 15, 2019
@pocmo pocmo self-assigned this Feb 21, 2019
@csadilek csadilek mentioned this issue Feb 21, 2019
Closed
@pocmo
Copy link
Contributor Author

pocmo commented Mar 5, 2019

Depends on #2243

pocmo added a commit to pocmo/android-components that referenced this issue Mar 5, 2019
@pocmo
Issue mozilla-mobile#2080: Extract website icon resources via WebExte…
7b5efea 
…nsion.
pocmo added a commit to pocmo/android-components that referenced this issue Mar 5, 2019
@pocmo
Issue mozilla-mobile#2080: Extract website icon resources via WebExte…
24d665c 
…nsion.
pocmo added a commit that referenced this issue Mar 6, 2019
@pocmo
Issue #2080: Extract website icon resources via WebExtension.
6c7ef7e
georgf pushed a commit to georgf/android-components that referenced this issue Mar 7, 2019
@pocmo @georgf
Issue mozilla-mobile#2080: Extract website icon resources via WebExte…
c3971bf 
…nsion.
@cpeterso
Copy link
Contributor

cpeterso commented Mar 7, 2019

I closed GV's favicon bug as WONTFIX because @snorp says A-C can fetch favicons themselves without a GV API.

https://bugzilla.mozilla.org/show_bug.cgi?id=1527618

@pocmo pocmo added the blocked Blocked pull requests and issues label Mar 21, 2019
@jhugman
Copy link
Contributor

jhugman commented Apr 3, 2019

Firefox iOS replaced a lot of handwritten JS with @mozilla/page-metadata-parser with great success.

I'd be interested in doing the same here.

@pocmo pocmo added the 🐉 Fenix Feature needed for Fenix label Apr 11, 2019
@cpeterso cpeterso mentioned this issue Apr 23, 2019
Closed
@cpeterso
Copy link
Contributor

@pocmo You added the blocked label to this issue back in March. What is this issue blocked on? GV WebExtension support? We decided in GV bug https://bugzilla.mozilla.org/show_bug.cgi?id=1527618 that GV would not (need to build) a GV API to share website icons because AC could write a WebExtension.

@pocmo
Copy link
Contributor Author

pocmo commented Apr 29, 2019

@cpeterso This was waiting for the messaging API in GV/AC. Not blocked anymore.

@pocmo pocmo removed the blocked Blocked pull requests and issues label Apr 29, 2019
@vesta0 vesta0 added the P1 label May 8, 2019
pocmo added a commit to pocmo/android-components that referenced this issue May 9, 2019
@pocmo
Issue mozilla-mobile#2080: Extract website icon resources via WebExte…
0a1d2ed 
…nsion.
pocmo added a commit to pocmo/android-components that referenced this issue May 10, 2019
@pocmo
Issue mozilla-mobile#2080: Extract website icon resources via WebExte…
a897486 
…nsion.
pocmo added a commit to pocmo/android-components that referenced this issue May 10, 2019
@pocmo
Issue mozilla-mobile#2080: Extract website icon resources via WebExte…
d8954e7 
…nsion.
pocmo added a commit to pocmo/android-components that referenced this issue May 10, 2019
@pocmo
Issue mozilla-mobile#2080: Extract website icon resources via WebExte…
c54ddf6 
…nsion.
pocmo added a commit to pocmo/android-components that referenced this issue May 10, 2019
@pocmo
Issue mozilla-mobile#2080: Extract website icon resources via WebExte…
0f0b2a0 
…nsion.
pocmo added a commit that referenced this issue May 10, 2019
@pocmo
Issue #2080: Extract website icon resources via WebExtension.
9cbca3e
@pocmo pocmo closed this as completed May 13, 2019
@pocmo pocmo added this to the 0.52.0 🥖 milestone May 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pocmo pocmo

Labels
🌟 feature New functionality and improvements 🐉 Fenix Feature needed for Fenix <icons> Components: ui-icons, browser-icons needs:gv To implement/fix this we need a new API in GeckoView P1
Projects
None yet
Milestone
0.52.0 🥖
Development

No branches or pull requests
4 participants
@pocmo @jhugman @cpeterso @vesta0