Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Set Search shortcuts off by default #12025

Closed
2 tasks
liuche opened this issue Jun 26, 2020 · 1 comment
Closed
2 tasks

Set Search shortcuts off by default #12025

liuche opened this issue Jun 26, 2020 · 1 comment
Assignees
@kglazko
Labels
eng:qa:verified QA Verified Feature:Search

Comments

@liuche
Copy link
Contributor

liuche commented Jun 26, 2020 •
edited by data-sync-user
Loading

This is only for new users, and shouldn't override settings for users who have made a choice about this setting (similar to the other default settings).

Acceptance Criteria

  • Search screen has "Shortcuts" toggled off by default (for new users)
  • Address bar > Show search shortcuts is off by default

┆Issue is synchronized with this Jira Task
@github-actions github-actions bot added the needs:triage Issue needs triage label Jun 26, 2020
@kglazko kglazko self-assigned this Jun 26, 2020
@kglazko kglazko added Feature:Search and removed needs:triage Issue needs triage labels Jun 26, 2020
kglazko pushed a commit that referenced this issue Jun 26, 2020
For #12025 Set Search Shortcuts Off By Default
6503194
kglazko pushed a commit that referenced this issue Jun 26, 2020
For #12025 Set Search Shortcuts Off By Default
7a6b5a5
kglazko pushed a commit that referenced this issue Jun 26, 2020
For #12025 Set Search Shortcuts Off By Default
ce5f988
kglazko pushed a commit that referenced this issue Jun 26, 2020
For #12025 Set Search Shortcuts Off By Default
bbf9cd8
kglazko pushed a commit to kglazko/fenix that referenced this issue Jun 26, 2020
For mozilla-mobile#12025: Set Search Shortcuts Off By Default
9e63a24
kglazko pushed a commit to kglazko/fenix that referenced this issue Jun 26, 2020
For mozilla-mobile#12025: Set Search Shortcuts Off By Default
cdf06e9
kglazko pushed a commit to kglazko/fenix that referenced this issue Jun 26, 2020
For mozilla-mobile#12025: Set Search Shortcuts Off By Default
0251609
kglazko pushed a commit to kglazko/fenix that referenced this issue Jun 26, 2020
For mozilla-mobile#12025: Set Search Shortcuts Off By Default
e30fce8
kglazko pushed a commit to kglazko/fenix that referenced this issue Jun 27, 2020
For mozilla-mobile#12025: Set Search Shortcuts Off By Default
f4e0908
kglazko pushed a commit that referenced this issue Jun 27, 2020
@kglazko
For #12025: Set Search Shortcuts Off By Default
2ac8496
@liuche liuche mentioned this issue Jun 27, 2020
Closed
12 tasks
@liuche liuche added the eng:qa:needed QA Needed label Jun 27, 2020
@lobontiumira
Copy link

Verified as fixed on the latest Nightly build from 6/29, and on Beta 6.0.0-beta.1, that:

  • search screen has "Shortcuts" toggled off by default (for new users),
  • address bar -> Show search shortcuts is off by default.

Devices:

  • Samsung Galaxy Tab A6 (Android 5.1.1),
  • Samsung Galaxy Tab S6 (Android 9),
  • Google Pixel (Android 10), and
  • Sony Xperia Z5 Premium (Android 7.1.1).

@lobontiumira lobontiumira added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jun 29, 2020
@data-sync-user data-sync-user changed the title Set Search shortcuts off by default FNX2-16766 ⁃ Set Search shortcuts off by default Aug 2, 2020
@data-sync-user data-sync-user changed the title FNX2-16766 ⁃ Set Search shortcuts off by default FNX3-15075 ⁃ Set Search shortcuts off by default Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-15075 ⁃ Set Search shortcuts off by default FNX-13041 ⁃ Set Search shortcuts off by default Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-13041 ⁃ Set Search shortcuts off by default FNX2-16766 ⁃ Set Search shortcuts off by default Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX2-16766 ⁃ Set Search shortcuts off by default Set Search shortcuts off by default May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kglazko kglazko

Labels
eng:qa:verified QA Verified Feature:Search
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@liuche @kglazko @lobontiumira @data-sync-user