For mozilla-mobile#12025: Set Search Shortcuts Off By Default

kglazko · Jun 26, 2020 · 0251609 · 0251609
1 parent df49db6
commit 0251609
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/app/src/main/java/org/mozilla/fenix/utils/Settings.kt b/app/src/main/java/org/mozilla/fenix/utils/Settings.kt
@@ -309,7 +309,7 @@ class Settings private constructor(
 
     val shouldShowSearchShortcuts by booleanPreference(
         appContext.getPreferenceKey(R.string.pref_key_show_search_shortcuts),
-        default = true
+        default = false
     )
 
     val shouldUseDarkTheme by booleanPreference(

diff --git a/app/src/test/java/org/mozilla/fenix/search/DefaultSearchControllerTest.kt b/app/src/test/java/org/mozilla/fenix/search/DefaultSearchControllerTest.kt
@@ -150,6 +150,10 @@ class DefaultSearchControllerTest {
     @Test
     fun `show search shortcuts when setting enabled AND query empty`() {
         val text = ""
+        testContext.settings().preferences
+                .edit()
+                .putBoolean(testContext.getString(R.string.pref_key_show_search_shortcuts), true)
+                .apply()
 
         controller.handleTextChanged(text)
 
@@ -160,6 +164,10 @@ class DefaultSearchControllerTest {
     fun `show search shortcuts when setting enabled AND query equals url`() {
         val text = "mozilla.org"
         every { session?.url } returns "mozilla.org"
+        testContext.settings().preferences
+                .edit()
+                .putBoolean(testContext.getString(R.string.pref_key_show_search_shortcuts), true)
+                .apply()
 
         assertEquals(text, session?.url)