Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug](Regression) The Add-ons are re-enabled after enabling "Run in private browsing" #10473

Closed
AndiAJ opened this issue May 7, 2020 · 1 comment
Closed

[Bug](Regression) The Add-ons are re-enabled after enabling "Run in private browsing" #10473

AndiAJ opened this issue May 7, 2020 · 1 comment
Assignees
@psymoon
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:WebExtensions S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist

Comments

@AndiAJ
Copy link
Collaborator

AndiAJ commented May 7, 2020 •
edited by data-sync-user
Loading

Prerequisites

Ublock Origin should be installed and enabled
"Run in private browsing" should not be disabled

Steps to reproduce

  1. Navigate to the Add-ons manager and open uBlock
  2. Enable "Run in private browsing" and quickly disable uBlock

Expected behavior

Ublock should be disabled

Actual behavior

Ublock is re-enabled automatically

Device information

  • Android device:
    • Google Pixel 3a (Android 10)
    • Huawei Mate 20 Lite (Android 9)
    • OnePlus A3 (Android 6.0.1)
  • Fenix version: Nightly build 200507 from 5/7

Notes

❗ Regression of #10195
❗ Other Add-ons are also impacted

► Video
20200507-104420

Noticed while re-checking #10196

┆Issue is synchronized with this Jira Task
@AndiAJ AndiAJ added 🐞 bug Crashes, Something isn't working, .. Feature:WebExtensions S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist labels May 7, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label May 7, 2020
@AndiAJ AndiAJ changed the title [Bug](Regression) The Add-ons are re-enabled after disabling "Run in private browsing" [Bug](Regression) The Add-ons are re-enabled after enabling "Run in private browsing" May 7, 2020
@AndiAJ AndiAJ mentioned this issue May 7, 2020
Closed
@psymoon psymoon self-assigned this May 7, 2020
psymoon added a commit to psymoon/fenix that referenced this issue May 8, 2020
@psymoon
For mozilla-mobile#10473: Fetch the addon from addon manager instead …
64d5257 
…from the store
psymoon added a commit to psymoon/fenix that referenced this issue May 8, 2020
@psymoon
For mozilla-mobile#10473: Fetch the addon from addon manager instead …
d624d3b 
…from the store
psymoon added a commit to psymoon/fenix that referenced this issue May 8, 2020
@psymoon
For mozilla-mobile#10473: Fetch the addon from addon manager instead …
338a77d 
…of the store
psymoon added a commit to psymoon/fenix that referenced this issue May 8, 2020
@psymoon
For mozilla-mobile#10473: Fetch the addon from addon manager instead …
68e9cbb 
…of the store
psymoon added a commit to psymoon/fenix that referenced this issue May 8, 2020
@psymoon
For mozilla-mobile#10473: Fetch the addon from addon manager instead …
0987bf5 
…of the store
liuche pushed a commit that referenced this issue May 8, 2020
@psymoon @liuche
For #10473: Fetch the addon from addon manager instead of the store
d58e7d3
@psymoon psymoon added the eng:qa:needed QA Needed label May 11, 2020
@ekager ekager removed the needs:triage Issue needs triage label May 11, 2020
@AndiAJ
Copy link
Collaborator Author

AndiAJ commented May 12, 2020

Hi, verified as fixed on the latest Nightly Build 200512 from 5/12 using the following devices:
• Google Pixel 3a (Android 10)
• Huawei Mate 20 Lite (Android 9)
• OnePlus A3 (Android 6.0.1)

► Video
20200512-102028

@AndiAJ AndiAJ closed this as completed May 12, 2020
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels May 12, 2020
@liuche liuche mentioned this issue May 19, 2020
Closed
32 tasks
@data-sync-user data-sync-user changed the title [Bug](Regression) The Add-ons are re-enabled after enabling "Run in private browsing" FNX2-15971 ⁃ [Bug](Regression) The Add-ons are re-enabled after enabling "Run in private browsing" Jul 30, 2020
@data-sync-user data-sync-user changed the title FNX2-15971 ⁃ [Bug](Regression) The Add-ons are re-enabled after enabling "Run in private browsing" FNX-4310 ⁃ [Bug](Regression) The Add-ons are re-enabled after enabling "Run in private browsing" Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX-4310 ⁃ [Bug](Regression) The Add-ons are re-enabled after enabling "Run in private browsing" FNX3-13922 ⁃ [Bug](Regression) The Add-ons are re-enabled after enabling "Run in private browsing" Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX3-13922 ⁃ [Bug](Regression) The Add-ons are re-enabled after enabling "Run in private browsing" FNX-4310 ⁃ [Bug](Regression) The Add-ons are re-enabled after enabling "Run in private browsing" Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-4310 ⁃ [Bug](Regression) The Add-ons are re-enabled after enabling "Run in private browsing" FNX2-15971 ⁃ [Bug](Regression) The Add-ons are re-enabled after enabling "Run in private browsing" Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX2-15971 ⁃ [Bug](Regression) The Add-ons are re-enabled after enabling "Run in private browsing" [Bug](Regression) The Add-ons are re-enabled after enabling "Run in private browsing" May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@psymoon psymoon

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:WebExtensions S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@psymoon @ekager @AndiAJ @data-sync-user