Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Private browsing setting can re-enable add-on #10195

Closed
AndiAJ opened this issue Apr 24, 2020 · 2 comments
Closed

[Bug] Private browsing setting can re-enable add-on #10195

AndiAJ opened this issue Apr 24, 2020 · 2 comments
Assignees
@psymoon
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:PrivateBrowsing Feature:WebExtensions needs:triage Issue needs triage S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist

Comments

@AndiAJ
Copy link
Collaborator

AndiAJ commented Apr 24, 2020 •
edited by data-sync-user
Loading

Prerequisites

Ublock Origin should be installed and enabled
"Run in private browsing" should not be disabled
Switch to Private Browsing

Steps to reproduce

  1. Navigate to the Add-ons manager and open uBlock
  2. Enable "Run in private browsing" and quickly disable uBlock

Expected behavior

Ublock should be disabled

Actual behavior

Ublock is re-enabled automatically

Device information

  • Android device: Google Pixel 3a (Android 10)
  • Fenix version: Nightly Build #21150608 from 4/24

Notes

► Video
20200424-170116

❗ Bumped into an isolated case where it gets disabled two times.

Steps to reproduce

  1. Disable "Run in private browsing"
  2. Quickly disable uBlock and exit to the Add-ons manager
  3. Open again uBlock

►Video
ezgif com-video-to-gif

Related to #6123

┆Issue is synchronized with this Jira Task
@AndiAJ AndiAJ added 🐞 bug Crashes, Something isn't working, .. S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist Feature:WebExtensions Feature:PrivateBrowsing labels Apr 24, 2020
@github-actions github-actions bot added the needs:triage Issue needs triage label Apr 24, 2020
@psymoon psymoon self-assigned this Apr 24, 2020
@csadilek csadilek changed the title [Bug]uBlock is re-enabled automatically [Bug] Private browsing setting can re-enabled add-on Apr 27, 2020
@csadilek csadilek changed the title [Bug] Private browsing setting can re-enabled add-on [Bug] Private browsing setting can re-enable add-on Apr 27, 2020
psymoon added a commit to psymoon/fenix that referenced this issue Apr 28, 2020
@psymoon
For mozilla-mobile#10195, mozilla-mobile#10196: Allow private browsin…
1c6f2ae 
…g mode switch to sync with enable state
psymoon added a commit to psymoon/fenix that referenced this issue Apr 28, 2020
@psymoon
For mozilla-mobile#10195, mozilla-mobile#10196: Allow private browsin…
de389e3 
…g mode switch to sync with enable state
psymoon added a commit to psymoon/fenix that referenced this issue May 1, 2020
@psymoon
For mozilla-mobile#10195, mozilla-mobile#10196: Allow private browsin…
db00b46 
…g mode switch to sync with enable state
psymoon added a commit to psymoon/fenix that referenced this issue May 1, 2020
@psymoon
For mozilla-mobile#10195, mozilla-mobile#10196: Allow private browsin…
27e7435 
…g mode switch to sync with enable state
Amejia481 pushed a commit that referenced this issue May 1, 2020
@psymoon @Amejia481
For #10195, #10196: Allow private browsing mode switch to sync with e…
3dcd52e 
…nable state
@Amejia481
Copy link
Contributor

@AndiAJ @psymoon landed a related patch, would mind retesting? :)

@Amejia481 Amejia481 added the eng:qa:needed QA Needed label May 1, 2020
@AndiAJ
Copy link
Collaborator Author

AndiAJ commented May 4, 2020

Hi, verified as fixed on the latest Nightly 200504 from 5/4 using the following devices:
• Google Pixel 3a (Android 10)
• Huawei Mate 20 Lite (Android 9)
• OnePlus A3 (Android 6.0.1)

► Video
20200504-112516

@AndiAJ AndiAJ closed this as completed May 4, 2020
@AndiAJ AndiAJ added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels May 4, 2020
@AndiAJ AndiAJ mentioned this issue May 7, 2020
Closed
@liuche liuche mentioned this issue May 19, 2020
Closed
32 tasks
@data-sync-user data-sync-user changed the title [Bug] Private browsing setting can re-enable add-on FNX2-15786 ⁃ [Bug] Private browsing setting can re-enable add-on Jul 30, 2020
@data-sync-user data-sync-user changed the title FNX2-15786 ⁃ [Bug] Private browsing setting can re-enable add-on FNX3-13714 ⁃ [Bug] Private browsing setting can re-enable add-on Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX3-13714 ⁃ [Bug] Private browsing setting can re-enable add-on FNX2-15786 ⁃ [Bug] Private browsing setting can re-enable add-on Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX2-15786 ⁃ [Bug] Private browsing setting can re-enable add-on FNX-3347 ⁃ [Bug] Private browsing setting can re-enable add-on Aug 10, 2020
@data-sync-user data-sync-user changed the title FNX-3347 ⁃ [Bug] Private browsing setting can re-enable add-on [Bug] Private browsing setting can re-enable add-on May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@psymoon psymoon

Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified Feature:PrivateBrowsing Feature:WebExtensions needs:triage Issue needs triage S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Amejia481 @psymoon @AndiAJ @data-sync-user