[Bug] Blue dot doesn't appear at all #10467
Comments
|
I think we changed this behavior on purpose in #7408 (comment) We only highlight these items once each until the user either interacts with them or closes the menu while they are displayed highlighted AFAICT, and the bottom menu icon is only highlighted if any items are highlighted. |
ekager
added
Feature:MainMenu
|
@ekager I agree that the behaviour should be as outlined her: #7408 (comment) However I took this part:
to mean that the blue dot will continue to appear every time user visits a NEW site for the first time, that supports reader view, open in app, PWA. @apbitner let us know which interpretation is correct. The current behaviour in Fenix is as follows: Upon a fresh install Blue dot only appears once per category and never again. So it appears the first time user visits a PWA site, the first time user visits a site that offers "Open in app" and the first time user visits a site that supports reader mode, and never again. This is not ideal user experience. |
|
I think eng interpreted "This could happen all at once on one page, or over time across multiple supported pages" to mean if one page has every category - readermode, PWA, open in app etc, that would knock them all out at once. Maintaining a list of every new site a user has visited in these categories and then querying that list every time the site changes to decide if we should highlight the menu is going to be an problem eng implementation wise. Wondering if we can just revert those changes and always show the highlight if one of these actions is available if we think it's important that users know when actions are available in the menu. |
|
Hey @ekager you are so right, querying a list of sites is just not feasible. I like your suggestion of always showing the highlight if one of these actions is available BUT having the notification go away as soon as user interacts with the menu (which wasn't the case during the very first iteration of this). Let's go ahead with that if it make sense. |
|
That sounds good to me. We're exploring replacing the blue dot notification so I'd hate for us to put too much eng effort into this. |
|
Noticed this issue when attempting to re-enable readability Reader Mode UI tests. Fresh clean install -> launch browser -> visit a reader capable local asset page -> expected a dot (no dot). This used to work fine, is Readability not working on local pages? |
|
Here's a test basic page: Load this in a fresh profile in Fenix. First launch, visit: <!DOCTYPE html>
<html>
<head>
<meta charset="utf-8" />
<title>RTL Test</title>
</head>
<body>
<main>
<article dir="rtl">
<h1>Lorem</h1>
<p>
Lorem ipsum dolor sit amet.
</p>
<p>
Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.
</p>
<p>
Tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.
</p>
</article>
</main>
</body>
</html>No blue notification dot. I assume this should work. Test page grabbed from https://github.com/mozilla/readability/tree/master/test/test-pages/rtl-4 where the metadata shows it as |
|
Hey @BranescuMihai are you still working on this? |
|
My issue is that readability is not working at all on first visit #11191 |
|
@vesta0 now that reader mode is moving to the address bar, that leaves us with Open in App and Install PWA in the toolbar menu. With Open in App, we are revisiting the overall flow which I believe Michelle has mentioned to you. With PWA's, our latest round of research around social containers indicates there's still a large user education challenge re: PWA's. I have not seen telemetry for either of these two features but can only presume it's pretty low based on the use case of Open in App, the relatively small % of PWA sites, and the lack of user awareness. Based on this, I suggest we remove the blue dot notification completely for these two remaining features in the toolbar menu, and only let it remain in use for What's New. |
|
@apbitner thanks for the update. I am ok with your recommendation on PWA for now but I'd like to revisit this once we have a better understanding of how often our users look to install a PWA site. |
|
@vesta0 so just to make sure, the actionable part of the task is now: remove the blue dot notification for PWA and Open in App? |
|
Adding the label |
vesta0
added
the
🙅 waiting
|
Now that #9506 won't be done before code freeze, we should make sure the blue dot DOES appear when it needs to. Let's go with the following variation of the behaviour we agreed upon previously: Show the blue dot only the first time either Open in App or PWA is available on a site AND have the notification go away once the user interacts with it. The bottom menu icon should only be highlighted if any menu items are highlighted. |
vesta0
removed
the
🙅 waiting
… to blue dot notification
|
@vesta0 as discussed, the behaviour is as follows: Show the dot when a user sees either |
|
Sounds good, thank you @BranescuMihai |
… to blue dot notification
|
Hi, verified as fixed on the latest ► Video |
data-sync-user
changed the title
data-sync-user
changed the title
data-sync-user
changed the title
data-sync-user
changed the title
data-sync-user
changed the title
data-sync-user
changed the title
Steps to reproduce
Navigate to a site with a PWA (e,g, Housing.com) or "Open in app" (e.g. instagram) available
Expected behavior
-See some sort of indication that PWA or Open in App is available.
-Be able to easily dismiss the indication/notification.
Actual behavior
No obvious indication/notification unless browser toolbar menu is opened.
Device information
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: