For mozilla-mobile#10467 - blue dot doesn't disappear on menu dismiss

BranescuMihai · Jun 25, 2020 · 830f653 · 830f653
1 parent 42098d9
commit 830f653
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 28 deletions.
diff --git a/app/src/main/java/org/mozilla/fenix/components/toolbar/BrowserInteractor.kt b/app/src/main/java/org/mozilla/fenix/components/toolbar/BrowserInteractor.kt
@@ -32,10 +32,6 @@ open class BrowserInteractor(
         browserToolbarController.handleToolbarItemInteraction(item)
     }
 
-    override fun onBrowserMenuDismissed(lowPrioHighlightItems: List<ToolbarMenu.Item>) {
-        browserToolbarController.handleBrowserMenuDismissed(lowPrioHighlightItems)
-    }
-
     override fun onScrolled(offset: Int) {
         browserToolbarController.handleScroll(offset)
     }

diff --git a/app/src/main/java/org/mozilla/fenix/components/toolbar/BrowserToolbarController.kt b/app/src/main/java/org/mozilla/fenix/components/toolbar/BrowserToolbarController.kt
@@ -53,7 +53,6 @@ interface BrowserToolbarController {
     fun handleToolbarClick()
     fun handleTabCounterClick()
     fun handleTabCounterItemInteraction(item: TabCounterMenuItem)
-    fun handleBrowserMenuDismissed(lowPrioHighlightItems: List<ToolbarMenu.Item>)
     fun handleReaderModePressed(enabled: Boolean)
 }
 
@@ -158,16 +157,6 @@ class DefaultBrowserToolbarController(
         }
     }
 
-    override fun handleBrowserMenuDismissed(lowPrioHighlightItems: List<ToolbarMenu.Item>) {
-        val settings = activity.settings()
-        lowPrioHighlightItems.forEach {
-            when (it) {
-                ToolbarMenu.Item.AddToHomeScreen -> settings.installPwaOpened = true
-                ToolbarMenu.Item.OpenInApp -> settings.openInAppOpened = true
-            }
-        }
-    }
-
     override fun handleScroll(offset: Int) {
         engineView.setVerticalClipping(offset)
     }

diff --git a/app/src/main/java/org/mozilla/fenix/components/toolbar/BrowserToolbarView.kt b/app/src/main/java/org/mozilla/fenix/components/toolbar/BrowserToolbarView.kt
@@ -50,7 +50,6 @@ interface BrowserToolbarViewInteractor {
     fun onBrowserToolbarMenuItemTapped(item: ToolbarMenu.Item)
     fun onTabCounterClicked()
     fun onTabCounterMenuItemTapped(item: TabCounterMenuItem)
-    fun onBrowserMenuDismissed(lowPrioHighlightItems: List<ToolbarMenu.Item>)
     fun onScrolled(offset: Int)
     fun onReaderModePressed(enabled: Boolean)
 }
@@ -229,7 +228,6 @@ class BrowserToolbarView(
                     bookmarksStorage = bookmarkStorage
                 )
                 view.display.setMenuDismissAction {
-                    interactor.onBrowserMenuDismissed(menuToolbar.getLowPrioHighlightItems())
                     view.invalidateActions()
                 }
             }

diff --git a/app/src/main/java/org/mozilla/fenix/components/toolbar/DefaultToolbarMenu.kt b/app/src/main/java/org/mozilla/fenix/components/toolbar/DefaultToolbarMenu.kt
@@ -137,17 +137,6 @@ class DefaultToolbarMenu(
         BrowserMenuItemToolbar(listOf(bookmark, share, forward, refresh))
     }
 
-    internal fun getLowPrioHighlightItems(): List<ToolbarMenu.Item> {
-        val lowPrioHighlightItems: MutableList<ToolbarMenu.Item> = mutableListOf()
-        if (canInstall() && installToHomescreen.isHighlighted()) {
-            lowPrioHighlightItems.add(ToolbarMenu.Item.InstallToHomeScreen)
-        }
-        if (shouldShowOpenInApp() && openInApp.isHighlighted()) {
-            lowPrioHighlightItems.add(ToolbarMenu.Item.OpenInApp)
-        }
-        return lowPrioHighlightItems
-    }
-
     // Predicates that need to be repeatedly called as the session changes
     private fun canAddToHomescreen(): Boolean =
         session != null && context.components.useCases.webAppUseCases.isPinningSupported() &&