This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Closes #6915: Add addon installation confirmation dialog #6916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6916 +/- ##
==========================================
Coverage 77.06% 77.06%
- Complexity 4836 4853 +17
==========================================
Files 650 651 +1
Lines 23803 23917 +114
Branches 3489 3501 +12
==========================================
+ Hits 18344 18432 +88
- Misses 4009 4026 +17
- Partials 1450 1459 +9
Continue to review full report at Codecov.
|
Amejia481
approved these changes
May 8, 2020
...es/browser/src/main/java/org/mozilla/samples/browser/addons/InstalledAddonDetailsActivity.kt
Outdated
Show resolved
Hide resolved
psymoon
commented
May 11, 2020
There was a problem hiding this comment.
The WebExtensionSupportTest CI failure:
[task 2020-05-11T16:51:54.697Z] [Robolectric] mozilla.components.support.webextensions.WebExtensionSupportTest.reacts to new extension being installed: sdk=28; resources=binary
[task 2020-05-11T16:51:54.797Z] I/MonitoringInstr: Instrumentation started!
[task 2020-05-11T16:51:54.797Z] I/MonitoringInstr: Setting context classloader to 'org.robolectric.internal.bytecode.SandboxClassLoader@54c56106', Original: 'org.robolectric.internal.bytecode.SandboxClassLoader@54c56106'
[task 2020-05-11T16:51:54.897Z] FAILURE
may be #6791.
Amejia481
approved these changes
May 11, 2020
...addons/src/main/java/mozilla/components/feature/addons/ui/AddonInstallationDialogFragment.kt
Outdated
Show resolved
Hide resolved
...ns/src/test/java/mozilla/components/feature/addons/ui/AddonInstallationDialogFragmentTest.kt
Outdated
Show resolved
Hide resolved
csadilek
suggested changes
May 11, 2020
...addons/src/main/java/mozilla/components/feature/addons/ui/AddonInstallationDialogFragment.kt
Outdated
Show resolved
Hide resolved
...addons/src/main/java/mozilla/components/feature/addons/ui/AddonInstallationDialogFragment.kt
Outdated
Show resolved
Hide resolved
...ns/src/test/java/mozilla/components/feature/addons/ui/AddonInstallationDialogFragmentTest.kt
Outdated
Show resolved
Hide resolved
...addons/src/main/java/mozilla/components/feature/addons/ui/AddonInstallationDialogFragment.kt
Outdated
Show resolved
Hide resolved
...addons/src/main/java/mozilla/components/feature/addons/ui/AddonInstallationDialogFragment.kt
Outdated
Show resolved
Hide resolved
samples/browser/src/main/java/org/mozilla/samples/browser/addons/AddonsFragment.kt
Outdated
Show resolved
Hide resolved
psymoon
force-pushed
the
installed-modal
branch
2 times, most recently
from
49d2be0 to
4b7aacc
Compare
csadilek
approved these changes
May 11, 2020
|
bors r=Amejia481, csadilek |
bors bot
pushed a commit
that referenced
this pull request
May 11, 2020
6916: Closes #6915: Add addon installation confirmation dialog r=Amejia481,csadilek a=psymoon Co-authored-by: Simon Chae <[email protected]>
|
Timed out. |
|
bors retry |
bors bot
pushed a commit
that referenced
this pull request
May 11, 2020
6916: Closes #6915: Add addon installation confirmation dialog r=Amejia481,csadilek a=psymoon 6947: Closes #6791: Intermittent test failure in WebExtensionSupport r=psymoon a=csadilek Basically, we dispatch a tab browser action to test that our action handler works, but that in turn changes the tab state triggering our flow again (see registerHandlersForNewSession). We can simply verify and capture the handlers first, then trigger actions to test them. Co-authored-by: Simon Chae <[email protected]> Co-authored-by: Christian Sadilek <[email protected]>
|
This PR was included in a batch that timed out, it will be automatically retried |
bors bot
pushed a commit
that referenced
this pull request
May 11, 2020
6916: Closes #6915: Add addon installation confirmation dialog r=Amejia481,csadilek a=psymoon Co-authored-by: Simon Chae <[email protected]>
|
Timed out. |
|
bors retry |
|
Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
After merge