Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Add a dialog for when add-on installation is completed. #6915

Closed
psymoon opened this issue May 8, 2020 · 0 comments
Closed

Add a dialog for when add-on installation is completed. #6915

psymoon opened this issue May 8, 2020 · 0 comments
Assignees
Labels
E5 Estimation points: 5 <web-extensions>

Comments

@psymoon
Copy link
Contributor

psymoon commented May 8, 2020

image

Fenix issue: mozilla-mobile/fenix#10398

┆Issue is synchronized with this Jira Task

@psymoon psymoon self-assigned this May 8, 2020
psymoon added a commit to psymoon/android-components that referenced this issue May 8, 2020
@psymoon psymoon added the E5 Estimation points: 5 label May 8, 2020
psymoon added a commit to psymoon/android-components that referenced this issue May 8, 2020
psymoon added a commit to psymoon/android-components that referenced this issue May 11, 2020
psymoon added a commit to psymoon/android-components that referenced this issue May 11, 2020
psymoon added a commit to psymoon/android-components that referenced this issue May 11, 2020
psymoon added a commit to psymoon/android-components that referenced this issue May 11, 2020
bors bot pushed a commit that referenced this issue May 11, 2020
6916: Closes #6915: Add addon installation confirmation dialog r=Amejia481,csadilek a=psymoon



Co-authored-by: Simon Chae <[email protected]>
bors bot pushed a commit that referenced this issue May 11, 2020
6916: Closes #6915: Add addon installation confirmation dialog r=Amejia481,csadilek a=psymoon



6947: Closes #6791: Intermittent test failure in WebExtensionSupport r=psymoon a=csadilek

Basically, we dispatch a tab browser action to test that our action handler works, but that in turn changes the tab state triggering our flow again (see registerHandlersForNewSession). We can simply verify and capture the handlers first, then trigger actions to test them.

Co-authored-by: Simon Chae <[email protected]>
Co-authored-by: Christian Sadilek <[email protected]>
bors bot pushed a commit that referenced this issue May 11, 2020
6916: Closes #6915: Add addon installation confirmation dialog r=Amejia481,csadilek a=psymoon



Co-authored-by: Simon Chae <[email protected]>
bors bot pushed a commit that referenced this issue May 12, 2020
6916: Closes #6915: Add addon installation confirmation dialog r=Amejia481,csadilek a=psymoon



6947: Closes #6791: Intermittent test failure in WebExtensionSupport r=psymoon a=csadilek

Basically, we dispatch a tab browser action to test that our action handler works, but that in turn changes the tab state triggering our flow again (see registerHandlersForNewSession). We can simply verify and capture the handlers first, then trigger actions to test them.

Co-authored-by: Simon Chae <[email protected]>
Co-authored-by: Christian Sadilek <[email protected]>
@bors bors bot closed this as completed in ce74add May 12, 2020
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Oct 24, 2022
… installation confirmation dialog

X-Channel-Revision: [main] mozilla-mobile/android-components@cf522a7
X-Channel-Revision: [main] mozilla-mobile/fenix@20b25d7
X-Channel-Revision: [main] mozilla-mobile/focus-android@29486b8
X-Channel-Converted-Revision: [ac-prep] mozilla-mobile/firefox-android@d6980d6
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Oct 24, 2022
… installation confirmation dialog

X-Channel-Revision: [main] mozilla-mobile/android-components@cf522a7
X-Channel-Revision: [main] mozilla-mobile/fenix@20b25d7
X-Channel-Revision: [main] mozilla-mobile/focus-android@29486b8
X-Channel-Converted-Revision: [ac-prep] mozilla-mobile/firefox-android@d6980d6
JohanLorenzo pushed a commit to JohanLorenzo/android-l10n that referenced this issue Oct 25, 2022
… installation confirmation dialog

X-Channel-Revision: [main] mozilla-mobile/android-components@cf522a7
X-Channel-Revision: [main] mozilla-mobile/fenix@20b25d7
X-Channel-Revision: [main] mozilla-mobile/focus-android@29486b8
X-Channel-Converted-Revision: [ac-prep] mozilla-mobile/firefox-android@d6980d6
JohanLorenzo pushed a commit to JohanLorenzo/android-l10n that referenced this issue Oct 25, 2022
… installation confirmation dialog

X-Channel-Revision: [main] mozilla-mobile/android-components@cf522a7
X-Channel-Revision: [main] mozilla-mobile/fenix@20b25d7
X-Channel-Revision: [main] mozilla-mobile/focus-android@29486b8
X-Channel-Converted-Revision: [ac-prep] mozilla-mobile/firefox-android@d6980d6
JohanLorenzo pushed a commit to JohanLorenzo/android-l10n that referenced this issue Oct 25, 2022
… installation confirmation dialog

X-Channel-Revision: [main] mozilla-mobile/android-components@cf522a7
X-Channel-Revision: [main] mozilla-mobile/fenix@20b25d7
X-Channel-Revision: [main] mozilla-mobile/focus-android@29486b8
X-Channel-Converted-Revision: [ac-prep] mozilla-mobile/firefox-android@d6980d6
JohanLorenzo pushed a commit to JohanLorenzo/android-l10n that referenced this issue Oct 25, 2022
… installation confirmation dialog

X-Channel-Revision: [main] mozilla-mobile/android-components@cf522a7
X-Channel-Revision: [main] mozilla-mobile/fenix@20b25d7
X-Channel-Revision: [main] mozilla-mobile/focus-android@29486b8
X-Channel-Converted-Revision: [ac-prep] mozilla-mobile/firefox-android@d6980d6
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Oct 25, 2022
… installation confirmation dialog

X-Channel-Revision: [main] mozilla-mobile/android-components@cf522a7
X-Channel-Revision: [main] mozilla-mobile/fenix@20b25d7
X-Channel-Revision: [main] mozilla-mobile/focus-android@29486b8
X-Channel-Converted-Revision: [ac-prep] mozilla-mobile/firefox-android@d6980d6
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Oct 26, 2022
… installation confirmation dialog

X-Channel-Revision: [main] mozilla-mobile/android-components@cf522a7
X-Channel-Revision: [main] mozilla-mobile/fenix@20b25d7
X-Channel-Revision: [main] mozilla-mobile/focus-android@29486b8
X-Channel-Converted-Revision: [ac-prep] mozilla-mobile/firefox-android@d6980d6
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Oct 27, 2022
… installation confirmation dialog

X-Channel-Revision: [main] mozilla-mobile/android-components@cf522a7
X-Channel-Revision: [main] mozilla-mobile/fenix@20b25d7
X-Channel-Revision: [main] mozilla-mobile/focus-android@29486b8
X-Channel-Converted-Revision: [ac-prep] mozilla-mobile/firefox-android@d6980d6
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Oct 27, 2022
… installation confirmation dialog

X-Channel-Revision: [main] mozilla-mobile/android-components@cf522a7
X-Channel-Revision: [main] mozilla-mobile/fenix@20b25d7
X-Channel-Revision: [main] mozilla-mobile/focus-android@29486b8
X-Channel-Converted-Revision: [ac-prep] mozilla-mobile/firefox-android@d6980d6
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Oct 27, 2022
… installation confirmation dialog

X-Channel-Revision: [main] mozilla-mobile/android-components@cf522a7
X-Channel-Revision: [main] mozilla-mobile/fenix@20b25d7
X-Channel-Revision: [main] mozilla-mobile/focus-android@29486b8
X-Channel-Converted-Revision: [ac-prep] mozilla-mobile/firefox-android@d6980d6
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 13, 2023
… installation confirmation dialog

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@d6980d6
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 13, 2023
… installation confirmation dialog

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@d6980d6
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 13, 2023
… installation confirmation dialog

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@d6980d6
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 13, 2023
… installation confirmation dialog

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@d6980d6
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 14, 2023
… installation confirmation dialog

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@d6980d6
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 14, 2023
… installation confirmation dialog

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@d6980d6
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 14, 2023
… installation confirmation dialog

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@d6980d6
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 14, 2023
… installation confirmation dialog

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@d6980d6
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 15, 2023
… installation confirmation dialog

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@d6980d6
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 15, 2023
… installation confirmation dialog

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@d6980d6
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 15, 2023
… installation confirmation dialog

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@d6980d6
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 16, 2023
… installation confirmation dialog

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@d6980d6
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 16, 2023
… installation confirmation dialog

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@d6980d6
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 16, 2023
… installation confirmation dialog

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@d6980d6
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 16, 2023
… installation confirmation dialog

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@d6980d6
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 16, 2023
… installation confirmation dialog

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@d6980d6
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 16, 2023
… installation confirmation dialog

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@d6980d6
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 16, 2023
… installation confirmation dialog

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@d6980d6
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 16, 2023
… installation confirmation dialog

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@d6980d6
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 16, 2023
… installation confirmation dialog

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@d6980d6
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 16, 2023
… installation confirmation dialog

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@d6980d6
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 17, 2023
… installation confirmation dialog

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@d6980d6
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 17, 2023
… installation confirmation dialog

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@d6980d6
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 17, 2023
… installation confirmation dialog

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@d6980d6
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 17, 2023
… installation confirmation dialog

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@d6980d6
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 17, 2023
… installation confirmation dialog

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@d6980d6
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 17, 2023
… installation confirmation dialog

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@d6980d6
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 17, 2023
… installation confirmation dialog

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@d6980d6
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 17, 2023
… installation confirmation dialog

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@d6980d6
mozilla-l10n-automation-bot pushed a commit to mozilla-l10n-automation-bot/android-l10n that referenced this issue Jan 18, 2023
… installation confirmation dialog

X-Channel-Revision: [main] mozilla-mobile/android-components@96444dd
X-Channel-Revision: [main] mozilla-mobile/fenix@d039188
X-Channel-Revision: [main] mozilla-mobile/focus-android@a9a09b1
X-Channel-Converted-Revision: [main] mozilla-mobile/firefox-android@d6980d6
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E5 Estimation points: 5 <web-extensions>
Projects
None yet
Development

No branches or pull requests

1 participant