-
Notifications
You must be signed in to change notification settings - Fork 473
For #12151 - Add support for empty step value in TimePicker #12802
Conversation
7e896a6
to
5bdb444
Compare
cf68968
to
b65380d
Compare
Let's wait till the branch is cut before landing this. Once this is soaked in Nightly and we see the crash is fixed, we can lift it to beta. Thanks |
This pull request has conflicts when rebasing. Could you fix it @Alexandru2909? 🙏 |
be3f989
to
f5de652
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch, LGTM!
Let's try to add formatting only to the areas that has been changed, as adding formatting to files makes reviewing a bit hard, as it's not straightforward what have been changed 😄.
This pull request has conflicts when rebasing. Could you fix it @Alexandru2909? 🙏 |
I tried formatting only the lines I changed but for me |
f5de652
to
e489e99
Compare
I tested the issue on Fenix Nightly 107.0a1 and the issue no longer occurs. Seconds and milliseconds can be selected without crashing from the example provided here: #12632. Device used:
|
@Mergifyio backport releases_v106.0.0 |
❌ No backport have been created
|
@Mergifyio backport releases/106.0 |
✅ Backports have been created
|
Fixes Fenix #26943.
Pull Request checklist
After merge
GitHub Automation
Fixes #12151