Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

For #12151 - Support step attribute in TimePicker #12632

Merged
merged 2 commits into from
Sep 8, 2022

Conversation

Alexandru2909
Copy link
Contributor

@Alexandru2909 Alexandru2909 commented Aug 10, 2022

Added second and millisecond picker as support for step attribute.
Picker can be tested here.

device-2022-08-10-124717.mp4

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

GitHub Automation

Fixes #12151

@Amejia481
Copy link
Contributor

Thanks for the PR!

It looks like we will need to updated PromptRequestTest to match the new arguments.

task 2022-08-10T10:03:28.563Z] > Task :concept-engine:compileReleaseUnitTestKotlin FAILED
[task 2022-08-10T10:03:28.563Z] e: /builds/worker/checkouts/vcs/components/concept/engine/src/test/java/mozilla/components/concept/engine/prompt/PromptRequestTest.kt: (101, 13): Too many arguments for public final fun TimeSelection(): Unit defined in mozilla.components.concept.engine.prompt.PromptRequestTest
[task 2022-08-10T10:03:28.563Z] e: /builds/worker/checkouts/vcs/components/concept/engine/src/test/java/mozilla/components/concept/engine/prompt/PromptRequestTest.kt: (102, 13): Too many arguments for public final fun TimeSelection(): Unit defined in mozilla.components.concept.engine.prompt.PromptRequestTest
[task 2022-08-10T10:03:28.563Z] e: /builds/worker/checkouts/vcs/components/concept/engine/src/test/java/mozilla/components/concept/engine/prompt/PromptRequestTest.kt: (103, 13): Too many arguments for public final fun TimeSelection(): Unit defined in mozilla.components.concept.engine.prompt.PromptRequestTest
[task 2022-08-10T10:03:28.563Z] e: /builds/worker/checkouts/vcs/components/concept/engine/src/test/java/mozilla/components/concept/engine/prompt/PromptRequestTest.kt: (104, 13): Too many arguments for public final fun TimeSelection(): Unit defined in mozilla.components.concept.engine.prompt.PromptRequestTest
[task 2022-08-10T10:03:28.564Z] e: /builds/worker/checkouts/vcs/components/concept/engine/src/test/java/mozilla/components/concept/engine/prompt/PromptRequestTest.kt: (105, 13): Too many arguments for public final fun TimeSelection(): Unit defined in mozilla.components.concept.engine.prompt.PromptRequestTest
[task 2022-08-10T10:03:28.564Z] e: /builds/worker/checkouts/vcs/components/concept/engine/src/test/java/mozilla/components/concept/engine/prompt/PromptRequestTest.kt: (106, 13): Too many arguments for public final fun TimeSelection(): Unit defined in mozilla.components.concept.engine.prompt.PromptRequestTest
[task 2022-08-10T10:03:28.564Z] e: /builds/worker/checkouts/vcs/components/concept/engine/src/test/java/mozilla/components/concept/engine/prompt/PromptRequestTest.kt: (106, 15): Cannot infer a type for this parameter. Please specify it explicitly.
[task 2022-08-10T10:03:28.564Z] e: /builds/worker/checkouts/vcs/components/concept/engine/src/test/java/mozilla/components/concept/engine/prompt/PromptRequestTest.kt: (107, 13): Too many arguments for public final fun TimeSelection(): Unit defined in mozilla.components.concept.engine.prompt.PromptRequestTest
[task 2022-08-10T10:03:28.564Z] e: /builds/worker/checkouts/vcs/components/concept/engine/src/test/java/mozilla/components/concept/engine/prompt/PromptRequestTest.kt: (108, 13): Too many arguments for public final fun TimeSelection(): Unit defined in mozilla.components.concept.engine.prompt.PromptRequestTest
[task 2022-08-10T10:03:28.564Z] e: /builds/worker/checkouts/vcs/components/concept/engine/src/test/java/mozilla/components/concept/engine/prompt/PromptRequestTest.kt: (111, 34): Unresolved reference: title
[task 2022-08-10T10:03:28.564Z] e: /builds/worker/checkouts/vcs/components/concept/engine/src/test/java/mozilla/components/concept/engine/prompt/PromptRequestTest.kt: (112, 34): Unresolved reference: type
[task 2022-08-10T10:03:28.564Z] e: /builds/worker/checkouts/vcs/components/concept/engine/src/test/java/mozilla/components/concept/engine/prompt/PromptRequestTest.kt: (113, 35): Unresolved reference: initialDate
[task 2022-08-10T10:03:28.564Z] e: /builds/worker/checkouts/vcs/components/concept/engine/src/test/java/mozilla/components/concept/engine/prompt/PromptRequestTest.kt: (114, 35): Unresolved reference: minimumDate
[task 2022-08-10T10:03:28.564Z] e: /builds/worker/checkouts/vcs/components/concept/engine/src/test/java/mozilla/components/concept/engine/prompt/PromptRequestTest.kt: (115, 35): Unresolved reference: maximumDate
[task 2022-08-10T10:03:28.564Z] e: /builds/worker/checkouts/vcs/components/concept/engine/src/test/java/mozilla/components/concept/engine/prompt/PromptRequestTest.kt: (117, 21): Unresolved reference: onConfirm
[task 2022-08-10T10:03:28.564Z] e: /builds/worker/checkouts/vcs/components/concept/engine/src/test/java/mozilla/components/concept/engine/prompt/PromptRequestTest.kt: (118, 21): Unresolved reference: onClear
[task 2022-08-10T10:03:28.663Z] 
[task 2022-08-10T10:03:28.663Z] FAILURE: Build failed with an exception.

@Amejia481 Amejia481 added the 🛬 needs landing PRs that are ready to land label Sep 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🛬 needs landing PRs that are ready to land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support step attribute in <input type="time"> etc
2 participants