This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 472
For #12151 - Support step attribute in TimePicker #12632
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexandru2909
requested review from
a team,
Amejia481 and
csadilek
as code owners
August 10, 2022 09:49
Amejia481
reviewed
Aug 12, 2022
.../prompts/src/main/java/mozilla/components/feature/prompts/dialog/TimePickerDialogFragment.kt
Outdated
Show resolved
Hide resolved
Thanks for the PR! It looks like we will need to updated
|
Amejia481
approved these changes
Sep 8, 2022
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added second and millisecond picker as support for
step
attribute.Picker can be tested here.
device-2022-08-10-124717.mp4
Pull Request checklist
After merge
GitHub Automation
Fixes #12151