For #12060 - Add support for select address prompt request #12101

Alexandru2909 · 2022-05-04T10:49:29Z

Added support for SelectAddress prompt request, following the changes in 10213.

Pull Request checklist

Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
Tests: This PR includes thorough tests or an explanation of why it does not
Changelog: This PR includes a changelog entry or does not need one
Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

mergify · 2022-05-04T17:37:17Z

This pull request has conflicts when rebasing. Could you fix it @Alexandru2909? 🙏

docs/changelog.md

...cept/storage/src/main/java/mozilla/components/concept/storage/CreditCardsAddressesStorage.kt

...ne-gecko/src/main/java/mozilla/components/browser/engine/gecko/prompt/GeckoPromptDelegate.kt

...ecko/src/test/java/mozilla/components/browser/engine/gecko/prompt/GeckoPromptDelegateTest.kt

...nents/concept/engine/src/main/java/mozilla/components/concept/engine/prompt/PromptRequest.kt

...s/concept/engine/src/test/java/mozilla/components/concept/engine/prompt/PromptRequestTest.kt

Alexandru2909 requested review from Amejia481 and csadilek as code owners May 4, 2022 10:49

Alexandru2909 force-pushed the 12060 branch from 68b7cae to b52b43e Compare May 4, 2022 11:23

Alexandru2909 requested a review from gabrielluong as a code owner May 4, 2022 11:23

gabrielluong removed request for csadilek and Amejia481 May 4, 2022 17:02

gabrielluong self-assigned this May 4, 2022

Alexandru2909 force-pushed the 12060 branch from b52b43e to d8082a0 Compare May 5, 2022 06:24

gabrielluong mentioned this pull request May 6, 2022

For #24855: Allow updating and deleting an existing address. mozilla-mobile/fenix#25031

Merged

3 tasks

gabrielluong suggested changes May 6, 2022

View reviewed changes

docs/changelog.md Outdated Show resolved Hide resolved

...cept/storage/src/main/java/mozilla/components/concept/storage/CreditCardsAddressesStorage.kt Outdated Show resolved Hide resolved

gabrielluong mentioned this pull request May 6, 2022

for #24931: create address label and description based on available data mozilla-mobile/fenix#25039

Merged

Alexandru2909 force-pushed the 12060 branch from d8082a0 to a9535a4 Compare May 6, 2022 07:21

gabrielluong self-requested a review May 6, 2022 17:59

gabrielluong added the 🕵️‍♀️ needs review PRs that need to be reviewed label May 6, 2022

gabrielluong approved these changes May 9, 2022

View reviewed changes

gabrielluong removed the 🕵️‍♀️ needs review PRs that need to be reviewed label May 9, 2022

gabrielluong linked an issue May 9, 2022 that may be closed by this pull request

Add support for select address prompt #12060

Closed

For mozilla-mobile#12060 - Add support for select address prompt request

04ac692

Alexandru2909 force-pushed the 12060 branch from a9535a4 to 04ac692 Compare May 9, 2022 07:18

Alexandru2909 added the 🛬 needs landing PRs that are ready to land label May 9, 2022

Merge branch 'main' into 12060

6683a02

mergify bot merged commit 1f25a70 into mozilla-mobile:main May 9, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

For #12060 - Add support for select address prompt request #12101

For #12060 - Add support for select address prompt request #12101

Alexandru2909 commented May 4, 2022

mergify bot commented May 4, 2022

For #12060 - Add support for select address prompt request #12101

For #12060 - Add support for select address prompt request #12101

Conversation

Alexandru2909 commented May 4, 2022

Pull Request checklist

After merge

mergify bot commented May 4, 2022