Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

For #12034 - Support reverse landscape orientation for fullscreen videos #12042

Merged
merged 2 commits into from
Apr 29, 2022

Conversation

indurs
Copy link
Contributor

@indurs indurs commented Apr 21, 2022

This allows users to view the full screen video both in landscape and reverse landscape even when auto rotate option is disabled in device settings

earth.mp4

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@indurs indurs requested a review from rocketsroger as a code owner April 21, 2022 05:55
@Mugurell
Copy link
Contributor

Seems like a test needs to be updated

 SUITE: mozilla.components.feature.media.fullscreen.MediaSessionFullscreenFeatureTest
   TEST: screen orientation is updated correctly
   FAILURE

 Argument(s) are different! Wanted:
 activity.setRequestedOrientation(11);
 -> at android.app.Activity.setRequestedOrientation(Activity.java)
 Actual invocations have different arguments:
 activity.setRequestedOrientation(6);
 -> at mozilla.components.feature.media.fullscreen.MediaSessionFullscreenFeature.processFullscreen(MediaSessionFullscreenFeature.kt:55)

@indurs
Copy link
Contributor Author

indurs commented Apr 21, 2022

Ok.. Thank You ! I will update the MediaSessionFullscreenFeatureTest

Copy link
Contributor

@Mugurell Mugurell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thank you @indurs .
Can you please add a note in changelog.md about this change and then we can land this?

@indurs
Copy link
Contributor Author

indurs commented Apr 29, 2022

@Mugurell , I've updated the changelog.md

@Mugurell Mugurell mentioned this pull request Apr 29, 2022
…fullscreen videos

This allows users to view the full screen video both in landscape and reverse landscape even when auto rotate option is disabled in device settings
@Mugurell Mugurell force-pushed the issue12034fix_branch branch from 0550557 to 2dd9fb0 Compare April 29, 2022 06:10
@Mugurell Mugurell added the 🛬 needs landing PRs that are ready to land label Apr 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🛬 needs landing PRs that are ready to land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants