Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Commit

Permalink
For #12034 - Support reverse landscape orientation for fullscreen videos
Browse files Browse the repository at this point in the history
This allows users to view the full screen video both in landscape and reverse landscape even when auto rotate option is disabled in device settings
  • Loading branch information
indurs authored and mergify[bot] committed Apr 29, 2022
1 parent fadd3f3 commit 8c2e29c
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ class MediaSessionFullscreenFeature(
ActivityInfo.SCREEN_ORIENTATION_USER_PORTRAIT
false ->
activity.requestedOrientation =
ActivityInfo.SCREEN_ORIENTATION_USER_LANDSCAPE
ActivityInfo.SCREEN_ORIENTATION_SENSOR_LANDSCAPE
else -> activity.requestedOrientation = ActivityInfo.SCREEN_ORIENTATION_USER
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ class MediaSessionFullscreenFeatureTest {
)

feature.start()
verify(mockActivity).setRequestedOrientation(ActivityInfo.SCREEN_ORIENTATION_USER_LANDSCAPE)
verify(mockActivity).setRequestedOrientation(ActivityInfo.SCREEN_ORIENTATION_SENSOR_LANDSCAPE)

store.dispatch(
MediaSessionAction.UpdateMediaFullscreenAction(
Expand Down
3 changes: 3 additions & 0 deletions docs/changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ permalink: /changelog/
* [Gecko](https://github.com/mozilla-mobile/android-components/blob/main/buildSrc/src/main/java/Gecko.kt)
* [Configuration](https://github.com/mozilla-mobile/android-components/blob/main/.config.yml)

* **feature-media**
* Support reverse landscape orientation for fullscreen videos
[issue # 12034](https://github.com/mozilla-mobile/android-components/issues/12034)
* **feature-downloads**:
* 🚒 Bug fixed [issue #11259](https://github.com/mozilla-mobile/android-components/issues/11259) - Improved mime type inference for when sharing images from the contextual menu.

Expand Down

0 comments on commit 8c2e29c

Please sign in to comment.