Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

URISyntaxException: illegal Intent URI format #6674

Closed
st3fan opened this issue Apr 16, 2020 · 0 comments
Closed

URISyntaxException: illegal Intent URI format #6674

st3fan opened this issue Apr 16, 2020 · 0 comments
Assignees
Labels
<app-links> Component: feature-app-links 💥 crash
Milestone

Comments

@st3fan
Copy link
Contributor

st3fan commented Apr 16, 2020

https://sentry.prod.mozaws.net/operations/firefox-beta/issues/7839465

We probably should just ignore URIs that throw an URISyntaxException

java.net.URISyntaxException: illegal Intent URI format at index 193: upi://pay?pa=SOMEDETAILREMOVEDHERE/CPI#Intent;
    at android.content.Intent.parseUri(Intent.java:5269)
    at mozilla.components.feature.app.links.AppLinksUseCases$GetAppLinkRedirect.invoke(AppLinksUseCases.kt:7)
    at mozilla.components.feature.app.links.AppLinksInterceptor.onLoadRequest(AppLinksInterceptor.kt:9)
    at org.mozilla.fenix.AppRequestInterceptor.onLoadRequest(AppRequestInterceptor.kt:3)
    at mozilla.components.browser.engine.gecko.GeckoEngineSession$createNavigationDelegate$1.onLoadRequest(GeckoEngineSession.kt:13)
    at org.mozilla.geckoview.GeckoSession$3.handleMessage(GeckoSession.java:41)
    at org.mozilla.geckoview.GeckoSession$3.handleMessage(GeckoSession.java:1)
    at org.mozilla.geckoview.GeckoSessionHandler.handleMessage(GeckoSessionHandler.java:2)
    at org.mozilla.gecko.EventDispatcher$3.run(EventDispatcher.java:1)
    at android.os.Handler.handleCallback(Handler.java:836)
    at android.os.Handler.dispatchMessage(Handler.java:103)
    at android.os.Looper.loop(Looper.java:203)
    at android.app.ActivityThread.main(ActivityThread.java:6339)
    at java.lang.reflect.Method.invoke(Method.java)
    at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1084)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:945)

┆Issue is synchronized with this Jira Task

@st3fan st3fan added <app-links> Component: feature-app-links 💥 crash labels Apr 16, 2020
@rocketsroger rocketsroger self-assigned this Apr 20, 2020
rocketsroger added a commit to rocketsroger/android-components that referenced this issue Apr 24, 2020
bors bot pushed a commit that referenced this issue Apr 28, 2020
6767: Close #6674: Don't crash in AppLinksUsesCases with illegal Intent URI format r=csadilek a=rocketsroger



6794:  GeckoView update (nightly) (20200428-140644) r=psymoon a=MickeyMoz



6795: Issue #6331: Update the generated top sites schemas r=Amejia481 a=gabrielluong

This is a follow up to #6715, where the top sites schema did not regenerate after fixing the review comments.



Co-authored-by: Roger Yang <[email protected]>
Co-authored-by: MickeyMoz <[email protected]>
Co-authored-by: Gabriel Luong <[email protected]>
@bors bors bot closed this as completed in e76f1f3 Apr 28, 2020
@rocketsroger rocketsroger added this to the 40.0.0 milestone Apr 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
<app-links> Component: feature-app-links 💥 crash
Projects
None yet
Development

No branches or pull requests

2 participants