Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Add isDefault bool to TopSiteEntity and APIs for flagging default top sites #6331

Closed
ekager opened this issue Mar 20, 2020 · 0 comments · Fixed by #6715
Closed

Add isDefault bool to TopSiteEntity and APIs for flagging default top sites #6331

ekager opened this issue Mar 20, 2020 · 0 comments · Fixed by #6715
Assignees
@gabrielluong
Labels
E1 Estimation points: 1 <top-sites> Component: feature-top-sites

Comments

@ekager
Copy link
Contributor

ekager commented Mar 20, 2020 •
edited by data-sync-user
Loading

Fenix wants to be able to have "default" top sites distinguishable at the db level.

Also helpful would be changing the consumer API to have getDefaultTopSites and getNonDefaultTopSites.

See mozilla-mobile/fenix#9286

┆Issue is synchronized with this Jira Task
@ekager ekager added the <top-sites> Component: feature-top-sites label Mar 20, 2020
@ekager ekager mentioned this issue Mar 20, 2020
Closed
@gabrielluong gabrielluong self-assigned this Mar 20, 2020
@psymoon psymoon added the E8 Estimation points: 8 label Mar 23, 2020
gabrielluong added a commit to gabrielluong/android-components that referenced this issue Apr 9, 2020
@gabrielluong
Issue mozilla-mobile#6331: Add isDefault bool to TopSiteEntity and AP…
70074ba 
…Is for flagging default top sites
gabrielluong added a commit to gabrielluong/android-components that referenced this issue Apr 9, 2020
@gabrielluong
Issue mozilla-mobile#6331: Add isDefault bool to TopSiteEntity and AP…
a98f29d 
…Is for flagging default top sites
gabrielluong added a commit to gabrielluong/android-components that referenced this issue Apr 17, 2020
@gabrielluong
Issue mozilla-mobile#6331: Add isDefault bool to TopSiteEntity and AP…
0cdbc5c 
…Is for flagging default top sites
gabrielluong added a commit to gabrielluong/android-components that referenced this issue Apr 19, 2020
@gabrielluong
Issue mozilla-mobile#6331: Add isDefault bool to TopSiteEntity and AP…
1c981ef 
…Is for flagging default top sites
gabrielluong added a commit to gabrielluong/android-components that referenced this issue Apr 20, 2020
@gabrielluong
Issue mozilla-mobile#6331: Add isDefault bool to TopSiteEntity and AP…
03cd770 
…Is for flagging default top sites
gabrielluong added a commit to gabrielluong/android-components that referenced this issue Apr 20, 2020
@gabrielluong
Issue mozilla-mobile#6331: Add isDefault bool to TopSiteEntity and AP…
baa19cb 
…Is for flagging default top sites
@gabrielluong gabrielluong mentioned this issue Apr 20, 2020
Merged
4 tasks
@gabrielluong gabrielluong added E1 Estimation points: 1 and removed E8 Estimation points: 8 labels Apr 20, 2020
gabrielluong added a commit to gabrielluong/android-components that referenced this issue Apr 20, 2020
@gabrielluong
Issue mozilla-mobile#6331: Add isDefault bool to TopSiteEntity and AP…
93f2cf6 
…Is for flagging default top sites
gabrielluong added a commit to gabrielluong/android-components that referenced this issue Apr 27, 2020
@gabrielluong
Issue mozilla-mobile#6331: Add isDefault bool to TopSiteEntity and AP…
1f92570 
…Is for flagging default top sites
gabrielluong added a commit to gabrielluong/android-components that referenced this issue Apr 27, 2020
@gabrielluong
Issue mozilla-mobile#6331: Add isDefault bool to TopSiteEntity and AP…
f505bc3 
…Is for flagging default top sites
@bors bors bot closed this as completed in b6245d8 Apr 28, 2020
gabrielluong added a commit to gabrielluong/android-components that referenced this issue Apr 28, 2020
@gabrielluong
Issue mozilla-mobile#6331: Update the generated top sites schemas
20a071c
bors bot pushed a commit that referenced this issue Apr 28, 2020
@MozLando @rocketsroger
@MickeyMoz @gabrielluong
Merge #6767 #6794 #6795
b3358c0 
6767: Close #6674: Don't crash in AppLinksUsesCases with illegal Intent URI format r=csadilek a=rocketsroger



6794:  GeckoView update (nightly) (20200428-140644) r=psymoon a=MickeyMoz



6795: Issue #6331: Update the generated top sites schemas r=Amejia481 a=gabrielluong

This is a follow up to #6715, where the top sites schema did not regenerate after fixing the review comments.



Co-authored-by: Roger Yang <[email protected]>
Co-authored-by: MickeyMoz <[email protected]>
Co-authored-by: Gabriel Luong <[email protected]>
gabrielluong added a commit to gabrielluong/android-components that referenced this issue Apr 29, 2020
@gabrielluong
Issue mozilla-mobile#6331: Update changelog to mention the new top si…
70ba9cf 
…te schema is a breaking change
gabrielluong added a commit to gabrielluong/android-components that referenced this issue Apr 29, 2020
@gabrielluong
Issue mozilla-mobile#6331: Update changelog to mention the new top si…
83dbefa 
…te schema is a breaking change
bors bot pushed a commit that referenced this issue Apr 29, 2020
@MozLando @gabrielluong @Amejia481
Merge #6803
5a403fe 
6803: Issue #6331: Update changelog to mention the new top site schema is a breaking change r=Amejia481 a=gabrielluong





Co-authored-by: Gabriel Luong <[email protected]>
Co-authored-by: Arturo Mejia <[email protected]>
@gabrielluong gabrielluong mentioned this issue Apr 30, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gabrielluong gabrielluong

Labels
E1 Estimation points: 1 <top-sites> Component: feature-top-sites
Projects
None yet
Milestone
No milestone
3 participants
@gabrielluong @psymoon @ekager