Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Upgrade detekt to 1.7.0 #6350

Closed
dector opened this issue Mar 23, 2020 · 0 comments
Closed

Upgrade detekt to 1.7.0 #6350

dector opened this issue Mar 23, 2020 · 0 comments
Labels
🏗️ build Build system, gradle, configuration 🔧 tooling Tooling for debugging and developing components
Milestone

Comments

@dector
Copy link
Contributor

dector commented Mar 23, 2020

┆Issue is synchronized with this Jira Task

@pocmo pocmo added 🏗️ build Build system, gradle, configuration 🔧 tooling Tooling for debugging and developing components labels Mar 23, 2020
dector added a commit to dector/android-components that referenced this issue Apr 4, 2020
And long constructors to baseline
dector added a commit to dector/android-components that referenced this issue May 24, 2020
And long constructors to baseline
dector added a commit to dector/android-components that referenced this issue May 24, 2020
bors bot pushed a commit that referenced this issue May 25, 2020
6353: #6350. Upgrade detekt to `1.9.1` r=jonalmeida a=dector

### Pull Request checklist
- [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
- [x] ~~**Tests**: This PR includes thorough tests or an explanation of why it does not~~
- [x] ~~**Changelog**: This PR includes [a changelog entry](https://github.com/mozilla-mobile/android-components/blob/master/docs/changelog.md) or does not need one~~
- [x] ~~**Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features~~

### After merge
- [ ] **Milestone**: Make sure issues closed by this pull request are added to the [milestone](https://github.com/mozilla-mobile/android-components/milestones) of the version currently in development.
- [ ] **Breaking Changes**: If this is a breaking change, please push a draft PR on [Reference Browser](https://github.com/mozilla-mobile/reference-browser) to address the breaking issues.


Co-authored-by: Denys M <[email protected]>
@dector dector closed this as completed May 26, 2020
@pocmo pocmo added this to the 43.0.0 milestone May 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🏗️ build Build system, gradle, configuration 🔧 tooling Tooling for debugging and developing components
Projects
None yet
Development

No branches or pull requests

2 participants