Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Commit

Permalink
Merge #6353
Browse files Browse the repository at this point in the history
6353: #6350. Upgrade detekt to `1.9.1` r=jonalmeida a=dector

### Pull Request checklist
- [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
- [x] ~~**Tests**: This PR includes thorough tests or an explanation of why it does not~~
- [x] ~~**Changelog**: This PR includes [a changelog entry](https://github.com/mozilla-mobile/android-components/blob/master/docs/changelog.md) or does not need one~~
- [x] ~~**Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md) or does not include any user facing features~~

### After merge
- [ ] **Milestone**: Make sure issues closed by this pull request are added to the [milestone](https://github.com/mozilla-mobile/android-components/milestones) of the version currently in development.
- [ ] **Breaking Changes**: If this is a breaking change, please push a draft PR on [Reference Browser](https://github.com/mozilla-mobile/reference-browser) to address the breaking issues.


Co-authored-by: Denys M <[email protected]>
  • Loading branch information
MozLando and dector committed May 25, 2020
2 parents b555019 + a499d44 commit 40b756b
Show file tree
Hide file tree
Showing 4 changed files with 82 additions and 191 deletions.
7 changes: 6 additions & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ buildscript {
}

plugins {
id("io.gitlab.arturbosch.detekt").version("1.0.1") // Check version number in `Versions.detekt`
id("io.gitlab.arturbosch.detekt").version("1.9.1") // Check version number in `Versions.detekt`
}

allprojects {
Expand Down Expand Up @@ -277,6 +277,8 @@ detekt {
config = files("$projectDir/config/detekt.yml")
baseline = file("$projectDir/config/detekt-baseline.xml")

failFast = false

reports {
html {
enabled = true
Expand All @@ -285,6 +287,9 @@ detekt {
xml {
enabled = false
}
txt {
enabled = false
}
}
}

Expand Down
2 changes: 1 addition & 1 deletion buildSrc/src/main/java/Dependencies.kt
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ object Versions {
const val android_gradle_plugin = "3.5.3"
const val android_maven_publish_plugin = "3.6.2"
const val lint = "26.3.2"
const val detekt = "1.2.2"
const val detekt = "1.9.1"

const val sentry = "1.7.21"
const val okhttp = "3.13.1"
Expand Down
Loading

0 comments on commit 40b756b

Please sign in to comment.