implement sync interval every 24 hours #756
Conversation
| @@ -90,7 +89,7 @@ open class DataStore( | |||
| .subscribe { state -> | |||
| when (state) { | |||
| is State.Locked -> clearList() | |||
| is State.Unlocked -> sync() | |||
| is State.Unlocked -> syncIfRequired() | |||
| // this will be triggered when the system time is very low due to device restarts | ||
| val currentTimeTooEarly = (syncTimerDate - currentSystemTime) > Constant.Common.twentyFourHours | ||
|
|
||
| return syncTimerDate < currentSystemTime || currentTimeTooEarly |
There was a problem hiding this comment.
Not sure I understand the name and comment currentTimeTooEarly.
syncTimerDate > currentSystemTime + twentyFourHoursOh, so if syncTimerDate (which should never be less than twenty four hours after the current time) is 24h after the current time, then we've had something weird happen, e.g. a reboot.
So, suggest: renaming currentTimeTooEarly to followingDeviceReboot.
val followingDeviceReboot = syncTimerDate > currentSystemTime + twentyFourHoursThere was a problem hiding this comment.
Incidentally, I'd put 24 hours as a property.
| open fun storeNextAutoLockTime() { | ||
| settingStore.autoLockTime | ||
| .take(1) | ||
| .subscribe(this::updateNextLockTime) | ||
| .addTo(compositeDisposable) | ||
| } | ||
|
|
||
| open fun storeNextSyncTime() { | ||
| storeSyncTimerDate(systemTimingSupport.systemTimeElapsed + Constant.Common.twentyFourHours) |
There was a problem hiding this comment.
Set Constant.Common.twentyFourHours as a property of TimingSupport.
e.g.
private val syncInterval = Constant.Common.twentyFourHoursThere was a problem hiding this comment.
I stuck it in the constants with the expectation that it will eventually become a setting that users can configure per #757 .
| } | ||
| } | ||
|
|
||
| private fun lockCurrentlyRequired(): Boolean { | ||
| val currentSystemTime = lockingSupport.systemTimeElapsed | ||
| val currentSystemTime = systemTimingSupport.systemTimeElapsed | ||
| return if (currentSystemTime <= Constant.Common.sixtySeconds) { |
There was a problem hiding this comment.
I'm not sure I understand why Constant.Common.sixtySeconds is not in a property — isn't autoLockInterval settable via SharedPreferences?
Fixes #735
Connected to #754
Testing and Review Notes
Currently, manual sync resets the 24 hour timer, so if you would like to see an automatic sync, don't sync manually!
To Do