Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

App syncs every time it's brought to the foreground #735

Closed
agi90 opened this issue Jun 4, 2019 · 7 comments · Fixed by #756
Closed

App syncs every time it's brought to the foreground #735

agi90 opened this issue Jun 4, 2019 · 7 comments · Fixed by #756
Assignees
Labels
defect Issue describes a defect that negatively impacts use. priority-P2

Comments

@agi90
Copy link

agi90 commented Jun 4, 2019

On my phone, Lockwise syncs whenever the app is brought to the foreground, which makes it very hard to use (especially on a slow connection). Right now it even syncs when the screen turns off and on.

I'm not totally sure if this is the intended behavior or if I hit a bug but I'm happy to add whatever debugging information you might need.

Phone: Samsung S10e
Version: Latest from playstore (6/4)

@devinreams devinreams added defect Issue describes a defect that negatively impacts use. priority-P2 labels Jun 6, 2019
@devinreams
Copy link
Contributor

Quick triage: currently by-design but high frequency, but not a great user experience (medium impact). Assigning P2.

Can fairly easily check and see if synced in the past X minutes, because users can still manually force a sync.

Can also consider ways to make the UI/UX available and responsive so as to not block the user.

@changecourse
Copy link
Contributor

I'd like to pose a one-time, 24hr default timer for automatically syncing, since we also have the ability for someone to trigger a manual sync if needed.

There would also be some good improvements to make around caching/storing logins for instances when sync fails, so access can still be available for 'last-synced' logins, but that's a separate issue.

@faogustavo
Copy link
Contributor

If we opt for the "delay" strategy, I think we should also add a new parameter in the settings screen. In this way, the user can manage the delay interval.

@sashei sashei self-assigned this Jun 12, 2019
@sashei
Copy link
Contributor

sashei commented Jun 12, 2019

@changecourse I'm making an assumption here that we should differentiate the manual sync and the auto sync in that performing a manual sync will not will change the next automatic sync time. what's your feeling about that? should manually syncing push back the next automatic sync time?

@changecourse
Copy link
Contributor

@sashei That's an interesting question... I could go either way, but my initial take would be that a manual sync would reset the timer.

@sashei
Copy link
Contributor

sashei commented Jun 12, 2019

@faogustavo that's a good suggestion; I think it's out of scope for this ticket but I've made a follow-up one: #757

@agi90
Copy link
Author

agi90 commented Jun 14, 2019

Thanks for fixing this!

@devinreams devinreams added this to the 1.1.2 - Stability milestone Jun 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
defect Issue describes a defect that negatively impacts use. priority-P2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants