This repository has been archived by the owner on Dec 14, 2021. It is now read-only.
Fixup no-username bugs (crash and string change) #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
jhugman
force-pushed
the
jhugman/488-no-username-fixes
branch
from
d5e7101 to
d6f76ff
Compare
| setTextViewText(R.id.hostname, title) | ||
| } | ||
|
|
||
| datasetBuilder.setValue( | ||
| it, | ||
| AutofillValue.forText(credential.username), | ||
| AutofillValue.forText(credential.username ?: ""), |
There was a problem hiding this comment.
what happens when the credential.username is null?
There was a problem hiding this comment.
When the credential.username is null, the empty string is used instead.
This means that the input field would be filled with the empty string rather than "null" (i.e. null.toString()).
There was a problem hiding this comment.
@eliserichards I've added steps to reproduce in the original issue #488. Please review when ready.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #488.
This PR fixes a crash caused by
kotlinx.androidauto generated code being incorrectly generated and incorrectly used. This PR does not address the generated code, which allowed:to be used, which resolves to
null.It also addresses an issue in autofill which caused strings containing "null" in display strings for autofill.