Use correct strings for no username in autofill.

mozilla-lockwise · Mar 11, 2019 · d6f76ff · d6f76ff
1 parent 9214217
commit d6f76ff
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/app/src/main/java/mozilla/lockbox/autofill/FillResponseBuilder.kt b/app/src/main/java/mozilla/lockbox/autofill/FillResponseBuilder.kt
@@ -97,25 +97,26 @@ open class FillResponseBuilder(
         val datasetBuilder = Dataset.Builder()
 
         val title = titleFromHostname(credential.hostname)
+        val username = credential.username ?: context.getString(R.string.no_username)
 
         parsedStructure.usernameId?.let {
             val presentation = RemoteViews(context.packageName, R.layout.autofill_item)
                 .apply {
-                    setTextViewText(R.id.autofillValue, credential.username)
+                    setTextViewText(R.id.autofillValue, username)
                     setTextViewText(R.id.hostname, title)
                 }
 
             datasetBuilder.setValue(
                 it,
-                AutofillValue.forText(credential.username),
+                AutofillValue.forText(credential.username ?: ""),
                 presentation
             )
         }
 
         parsedStructure.passwordId?.let {
             val presentation = RemoteViews(context.packageName, R.layout.autofill_item)
                 .apply {
-                    setTextViewText(R.id.autofillValue, context.getString(R.string.password_for, credential.username))
+                    setTextViewText(R.id.autofillValue, context.getString(R.string.password_for, username))
                     setTextViewText(R.id.hostname, title)
                 }