Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be more explicit about configs and where they come from #535

Merged
merged 6 commits into from
Oct 29, 2024
Merged

Be more explicit about configs and where they come from #535

merged 6 commits into from
Oct 29, 2024

Commits on Oct 29, 2024

  1. Reduce magic around configs 

    This allows us to remove a dependency (`everett`) while being clearer about
where configs come from. If something fails with a `KeyError` (or similar), we
can `grep` the codebase and find that value.

Jira: IAM-1443
    @bheesham
    bheesham committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    3a68146 View commit details
    Browse the repository at this point in the history

  2. OIDC provider metadata discovery is used 

    We don't need these since the discovery [is handled by Flask-pyoidc for us][pyoidc].

Jira: IAM-1443

[pyoidc]: https://github.com/zamzterz/Flask-pyoidc/blob/26b123572cba0b3fa84482c6c0270900042a73c9/src/flask_pyoidc/provider_configuration.py#L142-L144
    @bheesham
    bheesham committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    981b261 View commit details
    Browse the repository at this point in the history

  3. Document the envfile 

    Jira: IAM-1443
    @bheesham
    bheesham committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    4ce60bb View commit details
    Browse the repository at this point in the history

  4. config Fail on usage instead 

    Jira: IAM-1443
    @bheesham
    bheesham committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    17f73db View commit details
    Browse the repository at this point in the history

  5. config Make use of OIDC_REDIRECT_URI 

    Jira: IAM-1443
    @bheesham
    bheesham committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    31ed6f4 View commit details
    Browse the repository at this point in the history

  6. OIDC_REDIRECT_URI is used in Flask-pyoidc, not TokenVerification 

    I was confusing what this configuration value was used for. Turns out, we don't
make explicit use of this, though internally Flask-pyoidc does.

To clear up some confusion here I removed the bit of code from
TokenVerification.

Jira: IAM-1443
    @bheesham
    bheesham committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    784997c View commit details
    Browse the repository at this point in the history