Be more explicit about configs and where they come from #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bheesham
force-pushed
the
simpler-config
branch
from
2c23b5a
to
a35f124
Compare
|
Ou, actually, I found an issue. I'll re-do bits of this (specifically concerning the I'll mark this PR as a DO NOT MERGE for now. |
bheesham
commented
Oct 29, 2024
bheesham
changed the title
bheesham
changed the title
|
Should be resolved now -- I removed the bits in |
This allows us to remove a dependency (`everett`) while being clearer about where configs come from. If something fails with a `KeyError` (or similar), we can `grep` the codebase and find that value. Jira: IAM-1443
We don't need these since the discovery [is handled by Flask-pyoidc for us][pyoidc]. Jira: IAM-1443 [pyoidc]: https://github.com/zamzterz/Flask-pyoidc/blob/26b123572cba0b3fa84482c6c0270900042a73c9/src/flask_pyoidc/provider_configuration.py#L142-L144
Jira: IAM-1443
Jira: IAM-1443
Jira: IAM-1443
I was confusing what this configuration value was used for. Turns out, we don't make explicit use of this, though internally Flask-pyoidc does. To clear up some confusion here I removed the bit of code from TokenVerification. Jira: IAM-1443
bheesham
force-pushed
the
simpler-config
branch
from
8eef740
to
784997c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds/removes a couple of things:
env.sampleenv.sample, now shows the full keys we expect, along with some docs about where to get themeverett) -- this one did a bit of magic which I removed and implemented ourself (as a result it should be painfully clear what's missing on startup)OIDC_REDIRECT_URI-- we set this environment variable but never use itSee individual commits for a better review story.