Bug 1921383 - Bugzilla rich text editor shortcuts don't respect user layout (revised) #2336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dklawren
requested changes
Oct 3, 2024
There was a problem hiding this comment.
These changes break keyboard shortcuts for Linux on both stable and nightly. On production, I am able to do control-shift-. (period) to quote, as well as the shortcuts for number and un-ordered list. But with the latest changes, none of those actions work for me anymore. Same for Chrome on Linux. Actually this has been broken since #2331 and I didn't catch it before. Boo me.
|
I’m seeing the same issue on Windows. 😞 A fix incoming. Also, the (legacy) tab switching shortcut with |
dklawren
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug 1921383 - Bugzilla rich text editor shortcuts don't respect user layout
Sorry, #2331 was incomplete and broke shortcuts with non-alphanumeric keys like Space and Enter. Now I remember why I said “keyboard shortcuts not working sometimes” in my Sveltia UI change 😓 This does the right thing.