Bug 1904753: return immediately when approval flag should not be changed #2266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `set_attachment_approval_flags` we check for several conditions that indicate the flag cannot be updated by the user, but we do not immediately `return` when these conditions are hit. This causes the code to attempt to create the flag once it exits the loop, which is not allowed since approval flags are not multiplicable. Add `return` statements to branches which indicate the flag should not be updated. Since we are now returning early from these branches, we can reverse the logic of the main `if` branch to clean up the loop by de-denting the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
set_attachment_approval_flagswe check for several conditionsthat indicate the flag cannot be updated by the user, but we do not
immediately
returnwhen these conditions are hit. This causes thecode to attempt to create the flag once it exits the loop, which
is not allowed since approval flags are not multiplicable. Add
returnstatements to branches which indicate the flag should not be updated.
Since we are now returning early from these branches, we can reverse the
logic of the main
ifbranch to clean up the loop by de-denting the code.