Bug 1901945 - Can't go back to bug number page in the browser history after clicking on the Add reminder button #2258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dklawren
commented
Jun 12, 2024
dklawren
commented
- Replaces spaces with + in the needinfo string
- Use window.location.assign instead of replace so that back button works properly
… after clicking on the Add reminder button
globau
requested changes
Jun 12, 2024
globau
requested changes
Jun 12, 2024
extensions/BugModal/web/bug_modal.js
Outdated
| } | ||
| window.location.replace(`${BUGZILLA.config.basepath}userprefs.cgi?` + query_string); | ||
| window.location = `${BUGZILLA.config.basepath}userprefs.cgi?` + query_string; |
There was a problem hiding this comment.
Using string concatenation and interpolation isn't ideal; use one or the other (interpolation preferred).
cgsheeh
approved these changes
Jun 12, 2024
extensions/BugModal/web/bug_modal.js
Outdated
| @@ -918,9 +918,9 @@ $(function() { | |||
| query_string += `&bug_id=${BUGZILLA.bug_id}`; | |||
| } | |||
| if (has_needinfo_from) { | |||
| query_string += "¬e=Needinfo requested by " + encodeURIComponent(has_needinfo_from); | |||
| query_string += "¬e=Needinfo+requested+by+" + encodeURIComponent(has_needinfo_from); | |||
There was a problem hiding this comment.
Nit: you could do the same thing glob suggested here as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.