Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix urdf include #3026

Closed
wants to merge 6 commits into from
Closed

Fix urdf include #3026

wants to merge 6 commits into from

Conversation

sjahr
Copy link
Contributor

@sjahr sjahr commented Oct 10, 2024

Description

Based on #3003

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@sjahr sjahr requested a review from sea-bass October 10, 2024 18:04
moveit2.repos Outdated Show resolved Hide resolved
@rhaschke
Copy link
Contributor

Now, it's only srdfdom, which still seems to use the deprecated headers.

Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the selective include here in the moveit2 repo?
As far as I understood, that was only necessary for srdfdom, which only has a single branch for ros2. Here, we have different branches for rolling and older releases.

@sjahr
Copy link
Contributor Author

sjahr commented Oct 11, 2024

Closed in favor of #3003

@sjahr sjahr closed this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants