Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup msg includes: Use C++ instead of C header (backport #1844) #1849

Merged
merged 2 commits into from
Jan 9, 2023

Conversation

rhaschke
Copy link
Contributor

@rhaschke rhaschke commented Jan 7, 2023

Replacing #1847

@mergify
Copy link

mergify bot commented Jan 7, 2023

Please target the main branch for development, we will backport the changes to humble for you if approved and if they don't break API.

@rhaschke
Copy link
Contributor Author

rhaschke commented Jan 8, 2023

I really don't understand why GHA fails with including a moveit_msgs header file here.
Running industrial_ci locally works as expected.

@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Base: 50.94% // Head: 50.94% // No change to project coverage 👍

Coverage data is based on head (8b561d0) compared to base (fa640f8).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           humble    #1849   +/-   ##
=======================================
  Coverage   50.94%   50.94%           
=======================================
  Files         381      381           
  Lines       31891    31891           
=======================================
  Hits        16244    16244           
  Misses      15647    15647           
Impacted Files Coverage Δ
.../distance_field/src/propagation_distance_field.cpp 93.84% <ø> (ø)
moveit_ros/moveit_servo/src/servo_calcs.cpp 66.57% <ø> (ø)
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 75.36% <0.00%> (-1.07%) ⬇️
moveit_core/robot_state/src/robot_state.cpp 47.83% <0.00%> (-0.07%) ⬇️
...nning_scene_monitor/src/planning_scene_monitor.cpp 45.65% <0.00%> (+0.44%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rhaschke rhaschke merged commit b882b0b into moveit:humble Jan 9, 2023
@rhaschke rhaschke deleted the humble branch January 10, 2023 10:49
@moriarty moriarty mentioned this pull request May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants