-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more milestones and detail to ROS2 roadmap #17
Conversation
- [ ] Setup instructions | ||
- [ ] Install instructions | ||
- [ ] Ubuntu 18.04 | ||
- [ ] OS X 10.14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vmayoral my understanding is that you don't have plans to support OSX currently, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davetcoleman we discussed this internally and we're going to try to get OS X support as well. That's the initial effort at least.
- [ ] Convert moveit packages to ROS 2.0 | ||
- [x] ~~Include moveit_msgs in HRIM (**@ibaiape**)~~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vmayoral what is HRIM?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davetcoleman https://github.com/AcutronicRobotics/HRIM, discarded now as part of our contributions due to community's input. Refer to ros2/ros2#607 (comment)
- [ ] Update tutorials for MoveIt2 | ||
- [ ] Create tutorial on using ros1/ros2 bridge to support ros1 hardware drivers | ||
- [ ] Move install instructions to moveit.ros.org | ||
- [ ] Major refactoring and divergence from moveit2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rhaschke some of the breaking changes i'm hoping to do for moveit2, to be discussed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from moving to ROS2 structures instead of plugin interfaces - and this is not even listed here - I do not see a single item in this list I would hesitate to discuss for moveit-for-ros1's master
branch too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, well let's get past the ros1 release and master branch split and discuss that there!
Made some changes on top of this branch @ https://github.com/AcutronicRobotics/moveit2/tree/readme-milestones (don't have permissions to push here). |
@davetcoleman please cherry-pick AcutronicRobotics@8a2e766 |
@vmayoral Its difficult to discuss/debate your requested changes via your request to cherry-pick, some of them revert the point of my pull request so could you just request those changes here? you can use the github 'suggest' feature if you'd like. or you can make a follow-up PR after this one is merged in if you want to add more. |
- [x] Upgrade continuous integration for ROS 2.0 | ||
- [x] Refactor/cleanup folder hierarchy | ||
- [ ] Install instructions for Ubuntu 18.04 in README.md | ||
- [ ] Upgrade continuous integration for ROS 2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add item removed, not sure where though
- [ ] Upgrade continuous integration for ROS 2.0 | |
- [ ] Upgrade continuous integration for ROS 2.0 | |
- [x] Update/setup infrastructure for development | |
- [x] Delete metapackages | |
- [x] Upgrade continuous integration for ROS 2.0 | |
- [x] Refactor/cleanup folder hierarchy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I expanded these with more details, below:
- Delete excesses packages that are left over from rosbuild stacks: moveit_runtime, moveit_plugins, moveit_ros
- Rename non-package folders:
- rename moveit_planners to planners
- rename moveit_plugins to controller_interfaces
- Restructure folder layout of moveit repo:
- flatten moveit_ros folder to root of repo
- rename all moveit_ros folders with moveit_ros prefix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks good @davetcoleman
Co-Authored-By: davetcoleman <[email protected]>
Need approval so I can merge |
Co-Authored-By: davetcoleman <[email protected]>
* moveit commander * removing ref to pr2 and minor cleanup to moveit_commander tutorial * changing bold to code
No description provided.