Allow camera settings edit in single view.

[tunkio]

Enhancement to allow camera settings edit in single camera view. Previously the apply button didn't appear even when settings were changed.

[MichaIng]

@zagrim
Added you as reviewer since it complements the new single cam view implementation.

I didn't have a closer look at how cam settings behave when we merged this. Will do a test/comparison the next days.

[zagrim]

This seems ok to me. I never thought of the settings pane when doing the view switching changes, so nice to see a fix for that.

I noticed a small logical inconsistency (which has been there already before):
When in full-screen mode and clicking on config button in the camera frame, full-screen mode is exited (there's an explicit call to doExitFullScreenCamera in openSettings). However, it is still possible to have the settings pane open while full-screen by having the settings pane open when entering full-screen mode. And then, of course, there's no Apply button since the top-bar is not visible. So I think we should add a call to closeSettings to doFullScreenCamera.

[MichaIng]

So I think we should add a call to closeSettings to doFullScreenCamera.

Agreed, either we consequently exit full screen view when opening settings and hide the bar when entering full screen, or we show bar + settings panel while staying in full screen mode, when hitting settings button, hiding both when closing settings. The latter sounds difficult to implement, so adding closeSettings to doFullScreenCamera seems like the best solution for now. Shall we add it with this PR directly, or as dedicated PR?

[zagrim]

adding closeSettings to doFullScreenCamera seems like the best solution for now. Shall we add it with this PR directly, or as dedicated PR?

I'd do it here unless @tunkio objects, since it is related to the general topic. Myself I'd add the call before these lines but that's just a proposal:

    /* try to make browser window full screen */
    var element = document.documentElement;

[tunkio]

I don't object at all. This is the right place to do it. You can push the fix if you have time. I don't have time to do it right now. Long day ahead. Of course I can check and test it later.

[zagrim]

I added the call, and did a quick test.

[tunkio]

Tested it, seems to work properly. Thanks!

[MichaIng]

Works well here as well. Btw, what do you think about making the settings button a show/hide button, i.e. that settings are hidden when open? Now it is possible to close them with the top left button, but I caught myself trying this with the settings button within the camera frame 😉. At best the tooltip should then be adjusted as well, but not mandatory, IMO.

[tunkio]

No rush with this so it's possible to fix these usability things now. I'm bit busy next couple days but can give moment into this later!

[MichaIng]

Yes, definitely, let's get this merged. Created an own issue about the settings button: #2435