Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make camera settings button a show/hide one #2435

Closed
MichaIng opened this issue Apr 25, 2022 · 1 comment · Fixed by #2446
Closed

Make camera settings button a show/hide one #2435

MichaIng opened this issue Apr 25, 2022 · 1 comment · Fixed by #2446
Labels
enhancement HTML/HTTP JavaScript
Milestone
v0.43.1

Comments

@MichaIng
Copy link
Member

As suggested here: #2427 (comment)
Seems more intuitive to me, as currently clicking the button again does nothing.

An alternative would be to hide the settings button when settings are shown, so the top left hide button needs to be used.
@MichaIng MichaIng mentioned this issue Apr 25, 2022
Merged
tunkio added a commit to tunkio/motioneye that referenced this issue Apr 29, 2022
@tunkio
Camera settings button toggles configuration open/close. Fixes motion…
3e07ac6 
…eye-project#2435
@tunkio tunkio mentioned this issue Apr 29, 2022
Merged
@tunkio tunkio linked a pull request Apr 29, 2022 that will close this issue
Camera settings button toggles configuration open/close. Fixes #2435 #2446
Merged
MichaIng pushed a commit that referenced this issue Apr 30, 2022
@tunkio
Camera settings button toggles configuration open/close. Fixes #2435 (#…
ab23ae3 
…2446)
@MichaIng
Copy link
Member Author

Merged into dev 🚀.

@MichaIng MichaIng added this to the v0.43.0 milestone Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement HTML/HTTP JavaScript
Milestone
v0.43.1
Development

Successfully merging a pull request may close this issue.

Camera settings button toggles configuration open/close. Fixes #2435 tunkio/motioneye
1 participant
@MichaIng