-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TinyGltfImporter: more backporting #109
Commits on Oct 8, 2021
-
TinyGltfImporter: keep original buffer length for .glb conversion
Needed for test files that have smaller/larger sizes
Configuration menu - View commit details
-
Copy full SHA for 4f6bb93 - Browse repository at this point
Copy the full SHA 4f6bb93View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac8525a - Browse repository at this point
Copy the full SHA ac8525aView commit details -
Configuration menu - View commit details
-
Copy full SHA for fba9700 - Browse repository at this point
Copy the full SHA fba9700View commit details -
Configuration menu - View commit details
-
Copy full SHA for e85f528 - Browse repository at this point
Copy the full SHA e85f528View commit details -
Configuration menu - View commit details
-
Copy full SHA for 210e0b1 - Browse repository at this point
Copy the full SHA 210e0b1View commit details -
TinyGltfImporter: check for invalid scene hierarchies
- scene node list must only contain root nodes - nodes must not have multiple parents - cycle detection
Configuration menu - View commit details
-
Copy full SHA for 0cc0661 - Browse repository at this point
Copy the full SHA 0cc0661View commit details -
TinyGltfImporter: mesh spanning multiple buffers is now an error
Used to be an assert and consequently untested
Configuration menu - View commit details
-
Copy full SHA for e14551f - Browse repository at this point
Copy the full SHA e14551fView commit details -
TinyGltfImporter: support KHR_texture_basisu
The MSFT_texture_dds in the test files is there so other importers (CgltfImporter, really) can share test files. Also for CgltfImporter, the invalid basisu index test needs to be separate because that's checked by cgltf at import.
Configuration menu - View commit details
-
Copy full SHA for fb14494 - Browse repository at this point
Copy the full SHA fb14494View commit details -
Configuration menu - View commit details
-
Copy full SHA for 26d50e5 - Browse repository at this point
Copy the full SHA 26d50e5View commit details -
TinyGltfImporter: check skin attribute types
and mention their existence in the docs
Configuration menu - View commit details
-
Copy full SHA for 53c7fd2 - Browse repository at this point
Copy the full SHA 53c7fd2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4bf7267 - Browse repository at this point
Copy the full SHA 4bf7267View commit details -
Configuration menu - View commit details
-
Copy full SHA for 18ab4dc - Browse repository at this point
Copy the full SHA 18ab4dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 12ec21a - Browse repository at this point
Copy the full SHA 12ec21aView commit details -
Configuration menu - View commit details
-
Copy full SHA for b95e7a2 - Browse repository at this point
Copy the full SHA b95e7a2View commit details -
TinyGltfImporter: test more invalid accessors
The accessor checks for these were previously untested
Configuration menu - View commit details
-
Copy full SHA for c7e5375 - Browse repository at this point
Copy the full SHA c7e5375View commit details -
TinyGltfImporter: move non-OOB tests back to mesh-invalid.gltf
Originally moved out for CgltfImporter, but it doesn't perform these tests in openData() anymore, so they don't need to be in separate files
Configuration menu - View commit details
-
Copy full SHA for d86ee94 - Browse repository at this point
Copy the full SHA d86ee94View commit details -
TinyGltfImporter: fix compilation with MSVC 2015 and 2017
std::isdigit requires <cctype>, apparently MSVC 2019 transitively included it somewhere already
Configuration menu - View commit details
-
Copy full SHA for 9c4711f - Browse repository at this point
Copy the full SHA 9c4711fView commit details -
Configuration menu - View commit details
-
Copy full SHA for ea6db96 - Browse repository at this point
Copy the full SHA ea6db96View commit details -
Configuration menu - View commit details
-
Copy full SHA for 25b809d - Browse repository at this point
Copy the full SHA 25b809dView commit details -
TinyGltfImporter: check for normalized int mesh attributes
Not allowed, and used to lead to an assert in vertexFormat()
Configuration menu - View commit details
-
Copy full SHA for f74b5c7 - Browse repository at this point
Copy the full SHA f74b5c7View commit details
Commits on Oct 11, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 3aac997 - Browse repository at this point
Copy the full SHA 3aac997View commit details -
TinyGltfImporter: prefer strtol over atoi
It's used in other places already, be consistent and allow easier search for integer parsing
Configuration menu - View commit details
-
Copy full SHA for deffad9 - Browse repository at this point
Copy the full SHA deffad9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2bdc698 - Browse repository at this point
Copy the full SHA 2bdc698View commit details