Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TinyGltfImporter: more backporting #109

Closed

Commits on Oct 8, 2021

  1. TinyGltfImporter: keep original buffer length for .glb conversion

    Needed for test files that have smaller/larger sizes
    pezcode committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    4f6bb93 View commit details
    Browse the repository at this point in the history
  2. TinyGltfImporter: doc++

    pezcode committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    ac8525a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fba9700 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e85f528 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    210e0b1 View commit details
    Browse the repository at this point in the history
  6. TinyGltfImporter: check for invalid scene hierarchies

    - scene node list must only contain root nodes
    - nodes must not have multiple parents
    - cycle detection
    pezcode committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    0cc0661 View commit details
    Browse the repository at this point in the history
  7. TinyGltfImporter: mesh spanning multiple buffers is now an error

    Used to be an assert and consequently untested
    pezcode committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    e14551f View commit details
    Browse the repository at this point in the history
  8. TinyGltfImporter: support KHR_texture_basisu

    The MSFT_texture_dds in the test files is there so other importers (CgltfImporter, really) can share test files. Also for CgltfImporter, the invalid basisu index test needs to be separate because that's checked by cgltf at import.
    pezcode committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    fb14494 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    26d50e5 View commit details
    Browse the repository at this point in the history
  10. TinyGltfImporter: check skin attribute types

    and mention their existence in the docs
    pezcode committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    53c7fd2 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    4bf7267 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    18ab4dc View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    12ec21a View commit details
    Browse the repository at this point in the history
  14. TinyGltfImporter: cleanup

    pezcode committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    b95e7a2 View commit details
    Browse the repository at this point in the history
  15. TinyGltfImporter: test more invalid accessors

    The accessor checks for these were previously untested
    pezcode committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    c7e5375 View commit details
    Browse the repository at this point in the history
  16. TinyGltfImporter: move non-OOB tests back to mesh-invalid.gltf

    Originally moved out for CgltfImporter, but it doesn't perform these tests in openData() anymore, so they don't need to be in separate files
    pezcode committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    d86ee94 View commit details
    Browse the repository at this point in the history
  17. TinyGltfImporter: fix compilation with MSVC 2015 and 2017

    std::isdigit requires <cctype>, apparently MSVC 2019 transitively included it somewhere already
    pezcode committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    9c4711f View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    ea6db96 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    25b809d View commit details
    Browse the repository at this point in the history
  20. TinyGltfImporter: check for normalized int mesh attributes

    Not allowed, and used to lead to an assert in vertexFormat()
    pezcode committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    f74b5c7 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2021

  1. TinyGltfImporter: doc++

    pezcode committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    3aac997 View commit details
    Browse the repository at this point in the history
  2. TinyGltfImporter: prefer strtol over atoi

    It's used in other places already, be consistent and allow easier search for integer parsing
    pezcode committed Oct 11, 2021
    Configuration menu
    Copy the full SHA
    deffad9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2bdc698 View commit details
    Browse the repository at this point in the history