TinyGltfImporter: more backporting #109
Conversation
Needed for test files that have smaller/larger sizes
- scene node list must only contain root nodes - nodes must not have multiple parents - cycle detection
Used to be an assert and consequently untested
The MSFT_texture_dds in the test files is there so other importers (CgltfImporter, really) can share test files. Also for CgltfImporter, the invalid basisu index test needs to be separate because that's checked by cgltf at import.
and mention their existence in the docs
The accessor checks for these were previously untested
Originally moved out for CgltfImporter, but it doesn't perform these tests in openData() anymore, so they don't need to be in separate files
std::isdigit requires <cctype>, apparently MSVC 2019 transitively included it somewhere already
Codecov Report
@@ Coverage Diff @@
## master #109 +/- ##
==========================================
+ Coverage 94.86% 94.92% +0.05%
==========================================
Files 112 112
Lines 8874 8977 +103
==========================================
+ Hits 8418 8521 +103
Misses 456 456
Continue to review full report at Codecov.
|
Not allowed, and used to lead to an assert in vertexFormat()
I was wondering, should those non-cycle checks maybe be moved out of |
It's used in other places already, be consistent and allow easier search for integer parsing
There was a problem hiding this comment.
should those non-cycle checks maybe be moved out of
openData()?
I think this would be easier to do in the SceneData rework I'll be doing -- there it would only need to be handled in the doScene() call (which also takes care of all child objects). Here, as far as I can tell, you'd have to duplicate the handling also in doObject3D() (all of them? or only those that import the affected object? sounds complicated).
So I'd say keep it in doOpenData() and then I'll move it to doScene() during the port to new SceneData.
|
I applied the latest fixup commits to the rest and merged as 144716c...f7b29fd. Thank you! |
Here's the second set of changes for
TinyGltfImporter.Mostly consists of a bunch of changes backported from
CgltfImporterdeemed "bug/security/robustness" fixes. For slightly more background information, see #107 (comment) and #107 (comment).This also undoes some test file splits done in #106 because
CgltfImporterdoesn't depend oncgltf_validateanymore so those checks don't fail inopenData.