Authenticated user gets kicked when trying to connect with the same account with wrong credentials #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ccount even with wrong password.
| @@ -34,7 +35,7 @@ function handleConnect (client, packet, done) { | |||
| client.id = packet.clientId || uuid.v4() | |||
| client.will = packet.will | |||
|
|
|||
| client.broker.registerClient(client) | |||
| //client.broker.registerClient(client) | |||
There was a problem hiding this comment.
can you please remove this commented line?
|
Can you please add a unit test for this? |
|
This is incomplete as it prevents users to subscribe properly after authentication. Need to check deeper into the authentication procedure to check what it needs from the registration procedure. |
|
Thanks, would you mind adding a couple of unit tests as well? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authenticated user gets kicked when trying to connect another client instance with the same account even with wrong password.