remove parallel and use outgoingEnqueueCombi #131
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is using moscajs/aedes-persistence#13 & moscajs/aedes-persistence-redis#39 |
|
|
I would put it in CachedPersistence, are you ok with this? |
|
👍 |
Validate topics
Do not forward $SYS topics for +/# subscriptions.
|
this is now OK to go @mcollina 💪 |
|
Is there anything blocking this PR @mcollina to be merged? |
|
I'd like to have all persistences ported to the latest aedes-persistence/aedes-cached-persistence. |
|
This seems to need a rebase ! |
Remove qlobber from deps (it's used in aedes-persistence, not here)
This reverts commit e5d9c8a.
Guarantee granted always come in the right order
Clear up drain listeners in the case of an error
…ingEnqueueCombi # Conflicts: # package.json # test/basic.js
|
Something is a bit weird with github, could you rebase? |
|
I rebased the same PR, do you want me to create a new one? |
|
in favor of #152 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.