a very simple loop based outgoingEnqueueCombi base #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
reviewed
Jul 20, 2017
index.js
Outdated
| if (count === subs.length && !errord) { | ||
| cb() | ||
| } | ||
| } |
There was a problem hiding this comment.
This is going to be pretty hot. Can you use fastparallel?
There was a problem hiding this comment.
only for persistences that don't override outgoingEnqueueCombi ! BUT for sure :)
There was a problem hiding this comment.
I would like this to stay on par with what we had in aedes.
There was a problem hiding this comment.
Does it look good now @mcollina ?
|
I've just noticed that there are no test for |
|
Sure, I should update aedes-persistence tests |
|
The tests added in aedes-persistence 5.0.1 fails here, I can't release. |
|
let me check it |
|
I was trying to use aedes' fastparallel instance! However I think I should create one here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.