Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor instruction definitions from macros to classes #302

Merged
merged 64 commits into from
Oct 5, 2023
Merged

Refactor instruction definitions from macros to classes #302

merged 64 commits into from
Oct 5, 2023

Conversation

raccog
Copy link
Contributor

@raccog raccog commented Sep 22, 2023

Draft branch for #301.

mortbopet
mortbopet reviewed Sep 24, 2023
View reviewed changes
src/assembler/rvassembler_common.h Outdated Show resolved Hide resolved
src/assembler/rvassembler_common.h Outdated Show resolved Hide resolved
src/assembler/rvassembler_common.h Outdated Show resolved Hide resolved
@raccog
Remove unnecessary functions
1dba5ee
@raccog
Add descriptions for RISC-V ISA classes
8913b95
@raccog
Reimplement IShiftType64 RISC-V instruction as a template class
a300ab6
@raccog
Use RVOpcode class for RISC-V instruction classes
c15efc0
@raccog
Reimplement RType RISC-V instruction as a template class
c8b1d00
@raccog
Reimplement S-Type RISC-V instruction as a template class
1eae1dd
@raccog
Rename RISC-V immediate classes to match their instruction type
42cce30
@raccog
Reimplement U-Type RISC-V instruction as a template class
0e807de
@raccog
Rewrite comments describing RISC-V immediate classes
bec4676
@raccog
Reimplement J-Type RISC-V instruction as a template class
16d81d8
@raccog
Reimplement JALR-Type RISC-V instruction as a template class
39f2c85
@raccog
Fix field indices for S-Type RISC-V instructions
b250965
@raccog
Reimplement RISC-V pseudo-load instruction type as a template class
d7986ef
@raccog
Reimplement RISC-V pseudo-store instruction type as a template class
63f72ae
@raccog
Reimplement RISC-V CA-Type instruction as a template class
908f352
@raccog
Run clang-format
3f4f82f
@raccog
Reimplement RISC-V CI-Type instruction as a template class
d5bda7c 
Reimplemented for instructions `c.lwsp` and `c.flwsp`.
@raccog
Reimplement RISC-V CI-Type instruction as a template class
9676bd4 
Reimplemented for instructions `c.ldsp` and `c.fldsp`.
@raccog
Reimplement RISC-V CINOP-Type instruction as a template class
28c6120
@raccog
Use RVOpcode type as parameter for RVInstruction classes
2cea1cd
@raccog
Add class for CSS-Type instructions
fe3dfce
@raccog
Reimplement c.swsp and c.fswsp instructions
07396f1
@raccog
Reimplement c.sdsp and c.fsdsp instrutions
f824354
@raccog
Rename some RISC-V compressed register classes
f5747ab
@raccog
Reimplement c.lw and c.flw instructions
8cff43c
@raccog
Reimplement c.ld and c.fld instructions
98a29d7
@raccog
Reimplement c.sw, c.fsw, c.sd, and c.fsd instructions
535af18
@raccog
Fix 5-bit RV-C registers to use proper apply() and decode() functions
b29858c
@raccog
Remove unnecessary std::make_shared types
cc88a3a
@raccog
Use shared_ptr constructor instead of make_shared for instructions
b3e7a69
@raccog
Reimplement c.j and c.jal instructions
214134c
@raccog
Reimplement c.mv and c.add instructions
d6e1c0d
@raccog
Reimplement c.jr and c.jalr instructions
599d272
@raccog
Reimplement c.beqz and c.bnez instructions
cd8f422
@raccog
Reimplement c.srli, c.srai, and c.andi instructions
bd31486
@raccog
Reimplement c.addi4spn instruction
9ee06c9
@raccog
Change class comments to docstrings
3750828
@raccog
Fix some comments and change some class/variable names
7ca8927
@raccog raccog marked this pull request as ready for review September 29, 2023 17:51
mortbopet
mortbopet reviewed Sep 30, 2023
View reviewed changes
Copy link
Owner

@mortbopet mortbopet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's quite a few additional lines, but that were to be expected. I suspect changing these to structs (removes the public keyword) and potentially removing the Reg_T templating in the future, that will cut out a lot of the boilerplate in these files.

src/assembler/rvassembler_common.h Outdated Show resolved Hide resolved
src/assembler/rvassembler_common.h Outdated Show resolved Hide resolved
mortbopet
mortbopet approved these changes Oct 3, 2023
View reviewed changes
Copy link
Owner

@mortbopet mortbopet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the naming nit.

src/assembler/rv_c_ext.h Outdated Show resolved Hide resolved
@mortbopet
Copy link
Owner

Tip: most editors can enable clang-format on save (e.g. VSCode with https://marketplace.visualstudio.com/items?itemName=xaver.clang-format). Then you'll never run into CI complaining about it!

@raccog
Copy link
Contributor Author

raccog commented Oct 4, 2023

I have clang-format enabled on save in Qt Creator but it wouldn't format rv_c_ext.h for some reason. I had to format it manually with the command lol. Anyways, should be all set now.

@mortbopet mortbopet merged commit 27fcc58 into mortbopet:master Oct 5, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mortbopet mortbopet mortbopet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raccog @mortbopet