Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip]: Updates example to use expo SDK 47 #9

Merged
merged 8 commits into from
Feb 10, 2023
Merged

Conversation

brunokiafuka
Copy link
Collaborator

No description provided.

Copy link
Contributor

@Foosballfan Foosballfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@Foosballfan Foosballfan merged commit ae2a2bb into main Feb 10, 2023
@brunokiafuka brunokiafuka deleted the updates-example-sdk47 branch February 10, 2023 09:06
@luccasr73
Copy link

@brunokiafuka why removed android setup forwithAppBuildGradle and withAppBuildGradle?

@brunokiafuka
Copy link
Collaborator Author

@brunokiafuka why removed android setup forwithAppBuildGradle and withAppBuildGradle?

@luccasr73 both functions were used to perform Manual linking, which only required if you are on RN <0.60 as per the docs. Expo SDK 47 uses RN 0.70.5 so auto linking should be available.

Have you run into any issues after this change?

@luccasr73
Copy link

no errors, it was just a doubt, Im relatively new in react native ecosystem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants