Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Compatibility update for Expo SDK 46+ #7

Closed
ChronSyn opened this issue Jan 24, 2023 · 2 comments
Closed

[Bug] Compatibility update for Expo SDK 46+ #7

ChronSyn opened this issue Jan 24, 2023 · 2 comments
Assignees
@ChronSyn
Labels
bug Something isn't working

Comments

@ChronSyn
Copy link
Contributor

Issue
There have been a number of reports that the WatermelonDB config plugin is not working correctly with Expo SDK 46+.

Related issues:
#5 #6

Further notes
The plugin hasn't been updated since December 2021 and makes use of node internal imports such as fs and path.
With that in mind, it's a good time to consider updating the code to use functions which are specifically designed for config plugin development.
@ChronSyn ChronSyn self-assigned this Jan 24, 2023
@ChronSyn ChronSyn added the bug Something isn't working label Jan 24, 2023
@Foosballfan
Copy link
Contributor

@ChronSyn fixed in #8
Please will you test and publish to NPM?

@Foosballfan Foosballfan mentioned this issue Feb 9, 2023
Closed
@brunokiafuka
Copy link
Collaborator

#9 fixes this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChronSyn ChronSyn

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brunokiafuka @ChronSyn @Foosballfan